You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2014/04/08 23:54:05 UTC
[1/3] git commit: TS-898: annotate intentional switch fallthrough
Repository: trafficserver
Updated Branches:
refs/heads/master d6631a099 -> df9a3a6ab
TS-898: annotate intentional switch fallthrough
Coverity #1021906
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/dd608040
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/dd608040
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/dd608040
Branch: refs/heads/master
Commit: dd608040b8c05cc54fba29e9fbec0f4987c6dfc5
Parents: d6631a0
Author: James Peach <jp...@apache.org>
Authored: Sun Apr 6 12:39:23 2014 -0700
Committer: James Peach <jp...@apache.org>
Committed: Sun Apr 6 12:39:23 2014 -0700
----------------------------------------------------------------------
proxy/http/HttpClientSession.cc | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/dd608040/proxy/http/HttpClientSession.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpClientSession.cc b/proxy/http/HttpClientSession.cc
index aac7ef8..cfdbea3 100644
--- a/proxy/http/HttpClientSession.cc
+++ b/proxy/http/HttpClientSession.cc
@@ -498,6 +498,7 @@ HttpClientSession::state_api_callout(int event, void * /* data ATS_UNUSED */)
handle_api_return(event);
break;
+ // coverity[unterminated_default]
default:
ink_assert(false);
case HTTP_API_ERROR:
[2/3] git commit: Update HttpServerSession close debug message to
match the open one.
Posted by jp...@apache.org.
Update HttpServerSession close debug message to match the open one.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/aa45995e
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/aa45995e
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/aa45995e
Branch: refs/heads/master
Commit: aa45995e4c9e14f55417b71a9a00b1054e7bb233
Parents: dd60804
Author: James Peach <jp...@apache.org>
Authored: Tue Apr 8 14:01:13 2014 -0700
Committer: James Peach <jp...@apache.org>
Committed: Tue Apr 8 14:39:28 2014 -0700
----------------------------------------------------------------------
proxy/http/HttpServerSession.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/aa45995e/proxy/http/HttpServerSession.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpServerSession.cc b/proxy/http/HttpServerSession.cc
index 0609854..2feeeb6 100644
--- a/proxy/http/HttpServerSession.cc
+++ b/proxy/http/HttpServerSession.cc
@@ -119,8 +119,9 @@ HttpServerSession::do_io_close(int alerrno)
this->server_trans_stat--;
}
+ Debug("http_ss", "[%" PRId64 "] session closing, netvc %p", con_id, server_vc);
+
server_vc->do_io_close(alerrno);
- Debug("http_ss", "[%" PRId64 "] session closed", con_id);
server_vc = NULL;
HTTP_SUM_GLOBAL_DYN_STAT(http_current_server_connections_stat, -1); // Make sure to work on the global stat
[3/3] git commit: Make HttpSM::release_server_session slightly more
readable.
Posted by jp...@apache.org.
Make HttpSM::release_server_session slightly more readable.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/df9a3a6a
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/df9a3a6a
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/df9a3a6a
Branch: refs/heads/master
Commit: df9a3a6ab3a27753e4a9a76e322587c5c3c2960b
Parents: aa45995
Author: James Peach <jp...@apache.org>
Authored: Mon Mar 31 11:15:21 2014 -0700
Committer: James Peach <jp...@apache.org>
Committed: Tue Apr 8 14:41:48 2014 -0700
----------------------------------------------------------------------
proxy/http/HttpSM.cc | 52 ++++++++++++++++++++++++-----------------------
1 file changed, 27 insertions(+), 25 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/df9a3a6a/proxy/http/HttpSM.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
index 7e6fd13..80c5d78 100644
--- a/proxy/http/HttpSM.cc
+++ b/proxy/http/HttpSM.cc
@@ -4883,34 +4883,36 @@ HttpSM::mark_server_down_on_client_abort()
void
HttpSM::release_server_session(bool serve_from_cache)
{
- if (server_session != NULL) {
- if (t_state.current.server->keep_alive == HTTP_KEEPALIVE &&
- t_state.hdr_info.server_response.valid() &&
- (t_state.hdr_info.server_response.status_get() == HTTP_STATUS_NOT_MODIFIED ||
- (t_state.hdr_info.server_request.method_get_wksidx() == HTTP_WKSIDX_HEAD
- && t_state.www_auth_content != HttpTransact::CACHE_AUTH_NONE)) &&
- plugin_tunnel_type == HTTP_NO_PLUGIN_TUNNEL) {
- HTTP_DECREMENT_DYN_STAT(http_current_server_transactions_stat);
- server_session->server_trans_stat--;
- server_session->attach_hostname(t_state.current.server->name);
- if (t_state.www_auth_content == HttpTransact::CACHE_AUTH_NONE || serve_from_cache == false)
- server_session->release();
- else {
- // an authenticated server connection - attach to the local client
- // we are serving from cache for the current transaction
- t_state.www_auth_content = HttpTransact::CACHE_AUTH_SERVE;
- ua_session->attach_server_session(server_session, false);
- }
+ if (server_session == NULL) {
+ return;
+ }
+
+ if (t_state.current.server->keep_alive == HTTP_KEEPALIVE &&
+ t_state.hdr_info.server_response.valid() &&
+ (t_state.hdr_info.server_response.status_get() == HTTP_STATUS_NOT_MODIFIED ||
+ (t_state.hdr_info.server_request.method_get_wksidx() == HTTP_WKSIDX_HEAD
+ && t_state.www_auth_content != HttpTransact::CACHE_AUTH_NONE)) &&
+ plugin_tunnel_type == HTTP_NO_PLUGIN_TUNNEL) {
+ HTTP_DECREMENT_DYN_STAT(http_current_server_transactions_stat);
+ server_session->server_trans_stat--;
+ server_session->attach_hostname(t_state.current.server->name);
+ if (t_state.www_auth_content == HttpTransact::CACHE_AUTH_NONE || serve_from_cache == false) {
+ server_session->release();
} else {
- server_session->do_io_close();
+ // an authenticated server connection - attach to the local client
+ // we are serving from cache for the current transaction
+ t_state.www_auth_content = HttpTransact::CACHE_AUTH_SERVE;
+ ua_session->attach_server_session(server_session, false);
}
-
- ink_assert(server_entry->vc == server_session);
- server_entry->in_tunnel = true;
- vc_table.cleanup_entry(server_entry);
- server_entry = NULL;
- server_session = NULL;
+ } else {
+ server_session->do_io_close();
}
+
+ ink_assert(server_entry->vc == server_session);
+ server_entry->in_tunnel = true;
+ vc_table.cleanup_entry(server_entry);
+ server_entry = NULL;
+ server_session = NULL;
}
// void HttpSM::handle_post_failure()