You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/02/28 15:09:34 UTC

[GitHub] [ignite-3] tkalkirill commented on a change in pull request #685: IGNITE-16534 Make BplusMetaIo abstract

tkalkirill commented on a change in pull request #685:
URL: https://github.com/apache/ignite-3/pull/685#discussion_r815974574



##########
File path: modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/tree/BplusTree.java
##########
@@ -893,11 +897,12 @@ protected BplusTree(
             long metaPageId,
             @Nullable ReuseList reuseList,
             IoVersions<? extends BplusInnerIo<L>> innerIos,
-            IoVersions<? extends BplusLeafIo<L>> leafIos
+            IoVersions<? extends BplusLeafIo<L>> leafIos,

Review comment:
       I don't like this approach, it's clearer with the constructor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org