[GitHub] [couchdb] nickva commented on a change in pull request #2729: Don't advertise unimplemented features

[GitBox <gi...@apache.org>]

nickva commented on a change in pull request #2729: Don't advertise unimplemented features
URL: https://github.com/apache/couchdb/pull/2729#discussion_r399697472
 
 

 ##########
 File path: src/couch/src/couch_server.erl
 ##########
 @@ -238,13 +238,16 @@ init([]) ->
     couch_util:set_process_priority(?MODULE, high),
 
     % Mark pluggable storage engines as a supported feature
-    config:enable_feature('pluggable-storage-engines'),
+    % Not implemented on FDB
+    % config:enable_feature('pluggable-storage-engines'),
 
     % Mark partitioned databases as a supported feature
-    config:enable_feature(partitioned),
+    % Not implemented on FDB
+    % config:enable_feature(partitioned),
 
     % Mark being able to receive documents with an _access property as a supported feature
-    config:enable_feature('access-ready'),
 
 Review comment:
   We are _access ready technically so let's keep this one enabled. Though couch_server is probably the wrong place for it. We'd want it in fabric2_server eventually or other such place.
   
   https://github.com/apache/couchdb/blob/prototype/fdb-layer/src/couch/src/couch_doc.erl#L304

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services