You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/11/01 05:44:55 UTC
Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39719/#review104654
-----------------------------------------------------------
src/Makefile.am (lines 1165 - 1170)
<https://reviews.apache.org/r/39719/#comment162903>
You don't have to add a new binary. You can just add a subcommand for mesos-containerizer binary. See the example in src/containerizer/mesos/launch.hpp|cpp
- Jie Yu
On Oct. 31, 2015, 5:55 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39719/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2015, 5:55 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3806
> https://issues.apache.org/jira/browse/MESOS-3806
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed marking mounts as slave in ubuntu. More details please see MESOS-3806
>
>
> Diffs
> -----
>
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp a126cd6ee15adb8d92e85ab562e998e3647f999a
> src/slave/containerizer/mesos/mark_mounts_rslave.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39719/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>