You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@knox.apache.org by kr...@apache.org on 2019/09/05 00:11:53 UTC

[knox] 02/02: KNOX-2007 - TestHashicorpVaultAliasService fails if a process is already bound to port 8200

This is an automated email from the ASF dual-hosted git repository.

krisden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/knox.git

commit ebda495ce8bd52d63086f911f626f362be284c71
Author: Kevin Risden <kr...@apache.org>
AuthorDate: Wed Sep 4 20:10:52 2019 -0400

    KNOX-2007 - TestHashicorpVaultAliasService fails if a process is already bound to port 8200
    
    Signed-off-by: Kevin Risden <kr...@apache.org>
---
 .../backend/hashicorp/vault/TestHashicorpVaultAliasService.java  | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gateway-service-hashicorp-vault/src/test/java/org/apache/knox/gateway/backend/hashicorp/vault/TestHashicorpVaultAliasService.java b/gateway-service-hashicorp-vault/src/test/java/org/apache/knox/gateway/backend/hashicorp/vault/TestHashicorpVaultAliasService.java
index d746602..85430a9 100644
--- a/gateway-service-hashicorp-vault/src/test/java/org/apache/knox/gateway/backend/hashicorp/vault/TestHashicorpVaultAliasService.java
+++ b/gateway-service-hashicorp-vault/src/test/java/org/apache/knox/gateway/backend/hashicorp/vault/TestHashicorpVaultAliasService.java
@@ -70,7 +70,6 @@ public class TestHashicorpVaultAliasService {
   public static void setUpClass() {
     try {
       vaultContainer = new VaultContainer(vaultImage)
-                           .withVaultPort(vaultPort)
                            .withVaultToken(vaultToken)
                            .waitingFor(Wait.forHttp("/"));
     } catch (IllegalStateException e) {
@@ -96,7 +95,7 @@ public class TestHashicorpVaultAliasService {
   private void setupVaultSecretsEngine() throws Exception {
     vaultContainer.execInContainer("vault", "secrets", "enable", "-path=" + vaultSecretsEngine,
         "-version=2", "kv");
-    LOG.debug("created KV secrets engine %s", vaultSecretsEngine);
+    LOG.debug("created KV secrets engine {}", vaultSecretsEngine);
   }
 
   @After
@@ -109,7 +108,7 @@ public class TestHashicorpVaultAliasService {
 
   private void cleanupVaultSecretsEngine() throws Exception {
     vaultContainer.execInContainer("vault", "secrets", "disable", vaultSecretsEngine);
-    LOG.debug("deleted KV secrets engine %s", vaultSecretsEngine);
+    LOG.debug("deleted KV secrets engine {}", vaultSecretsEngine);
   }
 
   @AfterClass
@@ -270,14 +269,14 @@ public class TestHashicorpVaultAliasService {
     vaultContainer.copyFileToContainer(Transferable.of(policy.getBytes(StandardCharsets.UTF_8)),
         policyFilePath);
     vaultContainer.execInContainer("vault", "policy", "write", getVaultPolicy(), policyFilePath);
-    LOG.debug("created policy %s", getVaultPolicy());
+    LOG.debug("created policy {}", getVaultPolicy());
     vaultContainer.execInContainer("rm", "-f", policyFilePath);
   }
 
   private void cleanupVaultPolicy() {
     try {
       vaultContainer.execInContainer("vault", "policy", "delete", getVaultPolicy());
-      LOG.debug("deleted policy %s", getVaultPolicy());
+      LOG.debug("deleted policy {}", getVaultPolicy());
     } catch (Exception ignore) {
       // ignore
     }