You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Pavel Pereslegin (Jira)" <ji...@apache.org> on 2023/11/14 12:43:00 UTC

[jira] [Updated] (IGNITE-20855) Sql. Rework QueryTransactionWrapper to clean up the code.

     [ https://issues.apache.org/jira/browse/IGNITE-20855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Pereslegin updated IGNITE-20855:
--------------------------------------
    Description: 
It seems we can clean up the code if we move the code from {{wrapTxOrStartImplicit}} to {{QueryTransactionWrapper}}.

Basically the proposal is:
* add {{startTxIfNeeded}} non static *void* method to {{QueryTransactionWrapper}}, that will be responsible for starting implicit transaction and other checks that is now reside in static {{wrapTxOrStartImplicit}}.
* rework QueryTransactionWrapper test 

This will reduce the amount and complexity of code in SqlQueryProcessor (In particular when processing a multi-statements query).

  was:
It seems we can clean up the code if we move the code from {{wrapTxOrStartImplicit}} to {{QueryTransactionWrapper}}.

Basically the proposal is:
* add {{startTxIfNeeded}} non static *void* method to {{QueryTransactionWrapper}, that will be responsible for starting implicit transaction and other checks that is now reside in wrapTxOrStartImplicit.
* rework QueryTransactionWrapper test 

This will reduce the amount and complexity of code in SqlQueryProcessor.


> Sql. Rework QueryTransactionWrapper to clean up the code.
> ---------------------------------------------------------
>
>                 Key: IGNITE-20855
>                 URL: https://issues.apache.org/jira/browse/IGNITE-20855
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Pavel Pereslegin
>            Priority: Major
>              Labels: ignite-3
>
> It seems we can clean up the code if we move the code from {{wrapTxOrStartImplicit}} to {{QueryTransactionWrapper}}.
> Basically the proposal is:
> * add {{startTxIfNeeded}} non static *void* method to {{QueryTransactionWrapper}}, that will be responsible for starting implicit transaction and other checks that is now reside in static {{wrapTxOrStartImplicit}}.
> * rework QueryTransactionWrapper test 
> This will reduce the amount and complexity of code in SqlQueryProcessor (In particular when processing a multi-statements query).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)