You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/28 04:36:25 UTC

[GitHub] [incubator-seatunnel] ououtt opened a new pull request #1351: iceberg spark batch source

ououtt opened a new pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351


   #792 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] ououtt commented on pull request #1351: [Feature][Connectors]iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
ououtt commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1055137929


   > @ououtt Please add documentation to https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/spark/configuration/source-plugins , Thanks
   
   done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] ououtt commented on pull request #1351: [Feature][Connectors]iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
ououtt commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1056191562


   CodeQL / Analyze  false. What's the reason and how should I fix it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1351: [Feature][Connectors]iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1055172735


   @ououtt Please add the `common-options` option again, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1351: [Feature][Connectors] Add connector-spark-iceberg source

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1056436689


   Well done, looking forward to your next contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] ououtt commented on pull request #1351: iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
ououtt commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1054048063


   @CalvinKirs Ci passed. Can you review the code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1351: iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1054087620


   @wuchunfu Hi. PTAL thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] wuchunfu merged pull request #1351: [Feature][Connectors] Add connector-spark-iceberg source

Posted by GitBox <gi...@apache.org>.
wuchunfu merged pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] ououtt commented on pull request #1351: [Feature][Connectors]iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
ououtt commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1055186606


   > @ououtt Please add the `common-options` option again, thank you
   
   Thanks for reminding. Completed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1351: iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1054302372


   @ououtt Please add documentation to https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/spark/configuration/source-plugins , Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] ououtt commented on pull request #1351: [Feature][Connectors] Add connector-spark-iceberg source

Posted by GitBox <gi...@apache.org>.
ououtt commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1056455884


   @wuchunfu Thank you for your guidance. Maybe I can continue to do the sink spark plugin of iceberg


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] ououtt commented on pull request #1351: iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
ououtt commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1054007587


   > you can refer this :https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md
   
   Thank you for teaching me about license. I have edited the relevant files according to the instructions.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1351: iceberg spark batch source

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1351:
URL: https://github.com/apache/incubator-seatunnel/pull/1351#issuecomment-1053952984


   you can refer this :https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org