[GitHub] carbondata pull request #1297: [CARBONDATA-1429] Add a value based compressi...

[jackylk <gi...@git.apache.org>]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1297#discussion_r136248243
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java ---
    @@ -165,9 +165,28 @@ public double getDouble(int rowId) {
         return doubleData[rowId];
       }
     
    -  @Override
    -  public BigDecimal getDecimal(int rowId) {
    -    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  @Override public BigDecimal getDecimal(int rowId) {
    --- End diff --
    
    I think it is better to add a DecimalColumnPage instead of using FixLengthColumnPage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---