[GitHub] [cassandra] aweisberg commented on a diff in pull request #2220: CASSANDRA-18337: Operations.migrateReadRequiredOperations fails due to concurrent access when TransactionStatement is prepared

["aweisberg (via GitHub)" <gi...@apache.org>]

aweisberg commented on code in PR #2220:
URL: https://github.com/apache/cassandra/pull/2220#discussion_r1140559617


##########
src/java/org/apache/cassandra/cql3/statements/UpdateStatement.java:
##########
@@ -237,12 +246,14 @@ public static class ParsedInsertJson extends ModificationStatement.Parsed
     {
         private final Json.Raw jsonValue;
         private final boolean defaultUnset;
+        private final boolean isForTxn;
 
-        public ParsedInsertJson(QualifiedName name, Attributes.Raw attrs, Json.Raw jsonValue, boolean defaultUnset, boolean ifNotExists, StatementSource source)
+        public ParsedInsertJson(QualifiedName name, Attributes.Raw attrs, Json.Raw jsonValue, boolean defaultUnset, boolean ifNotExists, StatementSource source, boolean isForTxn)
         {
             super(name, StatementType.INSERT, attrs, null, ifNotExists, false, source);
             this.jsonValue = jsonValue;
             this.defaultUnset = defaultUnset;
+            this.isForTxn = isForTxn;

Review Comment:
   I think isForTxn is doesn't quite communicate that this is really for Accord so even CAS is included not just `TransactionStatement`. In some contexts we use lightweight transaction to describe CAS, but we don't always use this version for the modification statement for CAS just when it is on Accord.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org