[GitHub] [drill] arina-ielchiieva edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map

[GitBox <gi...@apache.org>]

arina-ielchiieva edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#issuecomment-515761557
 
 
   @paul-rogers 
   1. agree regarding naming  (it a least must have underscore `true_map`) but I agree that we need some better naming. canonical_map? Any other suggestions?
   2. Support was added for older framework but I agree that for EVF it should be added as well. Since you knowledge keeper for EVF could you please provide some guidelines where changes need to be done? Its' still crucial to add support for old framework since currently only two readers use new (EVF) (text and log format) and none of them support maps. This work was done primary for parquet reader (I am not sure when it will migrate to EVF). So to have maps in both is reasonable.
   3. I see there are unit tests in this PR, maybe not the ones are expected, could you please expand and give examples which tests do you expect.
   4. I believe there are some documentation in the Jira but I agree that better java-doc or readme.md should have been provided.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services