You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Alejandro Abdelnur (JIRA)" <ji...@apache.org> on 2012/05/31 19:56:22 UTC

[jira] [Created] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Alejandro Abdelnur created HADOOP-8459:
------------------------------------------

             Summary: make SecurityUtil.setTokenServiceUseIp method public
                 Key: HADOOP-8459
                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
             Project: Hadoop Common
          Issue Type: Improvement
          Components: security
    Affects Versions: 2.0.1-alpha
            Reporter: Alejandro Abdelnur
            Assignee: Alejandro Abdelnur
             Fix For: 2.0.1-alpha


Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HADOOP-8459.
---------------------------------

    
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.0-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.2-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286849#comment-13286849 ] 

Hadoop QA commented on HADOOP-8459:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530419/HADOOP-8459.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1063//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1063//console

This message is automatically generated.
                
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286894#comment-13286894 ] 

Alejandro Abdelnur commented on HADOOP-8459:
--------------------------------------------

Furthermore, HttpFS does not have hadoop conf/ directory in its classpath as it is a web app and its classpath is self-contained, thus it cannot load Hadoop site.xml files as resources.
                
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286891#comment-13286891 ] 

Alejandro Abdelnur commented on HADOOP-8459:
--------------------------------------------

HttpFS TokenManager will have to set that at HttpFS init/config time, HttpFS configuration and based on the HttpFS configuration this value must be set or not for HttpFS server. HttpFS configuration does not use the Configuration resources to create its configuration, thus it needs to be able to set it after reading HttpFS configuration.
                
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286913#comment-13286913 ] 

Daryn Sharp commented on HADOOP-8459:
-------------------------------------

Servers aren't responsible for setting the token service.  The client is responsible for setting the service to where it got the token.
                
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated HADOOP-8459:
---------------------------------------

    Attachment: HADOOP-8459.patch
    
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286922#comment-13286922 ] 

Daryn Sharp commented on HADOOP-8459:
-------------------------------------

To elaborate: consider the case of the client gets a token from "httpfs.domain" which is a CNAME to "host1234.domain".  The server can't know the host name the client used, so it would stamp "host1234.domain" into the token.  When the client tries to re-establish a connection to "httpfs.domain" it won't find a token with that hostname, hence why the client is responsible for setting the service.
                
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated HADOOP-8459:
---------------------------------------

    Status: Patch Available  (was: Open)
    
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286883#comment-13286883 ] 

Daryn Sharp commented on HADOOP-8459:
-------------------------------------

Whoa!  The setting of whether tokens are ip or host based must be homogenous across the cluster.  As soon as you flip this bit to get one token, you ruined all the other tokens.

Please provide an explanation of what you are trying to do so we can come up with the proper solution.
                
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8459) make SecurityUtil.setTokenServiceUseIp method public

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated HADOOP-8459:
---------------------------------------

    Resolution: Invalid
        Status: Resolved  (was: Patch Available)

@Daryn, thanks for the explanation, closing as invalid
                
> make SecurityUtil.setTokenServiceUseIp method public
> ----------------------------------------------------
>
>                 Key: HADOOP-8459
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8459
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8459.patch
>
>
> Changing the scope of this method to be able to use it for HttpFS delegation token support HDFS-3113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira