[GitHub] [superset] michael-s-molina commented on a change in pull request #16160: feat: change query predicate to text

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #16160:
URL: https://github.com/apache/superset/pull/16160#discussion_r686033458



##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -616,7 +616,12 @@ class DatasourceEditor extends React.PureComponent {
                 'values from the table. Typically the intent would be to limit the scan ' +
                 'by applying a relative time filter on a partitioned or indexed time-related field.',
             )}
-            control={<TextControl controlId="fetch_values_predicate" />}
+            control={
+              <TextAreaControl
+                language="sql"
+                controlId="fetch_values_predicate"
+              />

Review comment:
       ```suggestion
                 <TextAreaControl
                   language="sql"
                   controlId="fetch_values_predicate"
                   minLines={5}
                   maxLines={20}
                 />
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org