You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/15 11:45:41 UTC
[GitHub] KellenSunderland opened a new pull request #11302: [MXNET-553]
Restructure dockcross dockerfiles to fix caching
KellenSunderland opened a new pull request #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching
URL: https://github.com/apache/incubator-mxnet/pull/11302
## Description ##
This PR restructures the dockcross Dockerfiles to remove their multi-head components. This multi-head component made it difficult to properly provide a remote cache for the Dockerfiles, and was slowing down builds. A simple work-around for this was to generalize the ubuntu_ccache.sh file such that it works with ubuntu, debian, and in cross-compilation containers. We can now use this script the same way in a variety of containers, which eliminates the need for a special multi-head docker stage.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- x] All changes have test coverage:
- Ran test_docker_cache.py, ensured both existing tests pass.
- [x] Code is well-documented:
- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services