You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/09/03 12:47:10 UTC

[GitHub] andrzej-kaczmarek commented on issue #1375: [DO NOT MERGE] I2C retries - Driver

andrzej-kaczmarek commented on issue #1375: [DO NOT MERGE] I2C retries - Driver
URL: https://github.com/apache/mynewt-core/pull/1375#issuecomment-418105319
 
 
   This looks good to me and I prefer these helpers over extending HAL.
   Perhaps you may just consider moving this helper package to `hw/drivers/util/i2cn` so `hw/drivers/i2c` "namespace" can be used for I2C driver layer with bus arbitration etc. (something I mentioned on dev list - I can prepare more concrete proposal and send for discussion). But since this is separate directory and package I think it can live in its current place as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services