[GitHub] [maven-resolver] cstamas commented on pull request #77: [MRESOLVER-145] SyncContext implementations

[GitBox <gi...@apache.org>]

cstamas commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751683148


   Howdy @rmannibucau 
   For now I consider both HZ and Redisson as "lab" implementation still, due these:
   * for HZ to work we either must use deprecated HZ 3.x call (HazelcastInstance#getSemaphore), or have a remote CP cluster set up (here, setup is somewhat similar to Redisson: you must have some remote "thing", server, cluster set up beforehand)
   * for Redisson, no clue how to test (any ideas?)
   
   So for start, I'd focus on local (JVM local) locks and the two "extra" (again, for testing purposes: global and nolock) implementations. As they are pretty much in place. Given this PR does not include any of HZ or Redisson code into resolver (they are separate modules, it leaves it to integrator), I think we still have time to solve both questions, that IMO are valid and actually sounds useful (generic props for configuration).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org