[GitHub] [spark] attilapiros edited a comment on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

[GitBox <gi...@apache.org>]

attilapiros edited a comment on pull request #33936:
URL: https://github.com/apache/spark/pull/33936#issuecomment-915178351


   > I'm afraid this might kill the shell if a command is running for a long time? it triggers on commands.
   
   @srowen 
   
   I do not think as before the command is started the timer was stopped (and restarted after the command is finished):
   ```
       stopInactivityTimer()
       super.command(line)
       startInactivityTimer()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org