You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/06/29 17:45:34 UTC

[GitHub] [ignite] sanpwc opened a new pull request #7973: IGNITE-13060-tracing-engine

sanpwc opened a new pull request #7973:
URL: https://github.com/apache/ignite/pull/7973


   Tracing configuration engine + communication, exchange and discovery tracing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] nizhikov commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r447435114



##########
File path: examples/src/main/java/org/apache/ignite/examples/opencensus/OpenCensusMetricsExporterExample.java
##########
@@ -31,7 +31,7 @@
 import org.apache.ignite.IgniteCache;
 import org.apache.ignite.Ignition;
 import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.spi.metric.opencensus.OpenCensusMetricExporterSpi;
+import org.apache.ignite.opencensus.spi.metric.OpenCensusMetricExporterSpi;

Review comment:
       Why this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] sanpwc commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
sanpwc commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r452668211



##########
File path: examples/src/main/java/org/apache/ignite/examples/opencensus/OpenCensusMetricsExporterExample.java
##########
@@ -31,7 +31,7 @@
 import org.apache.ignite.IgniteCache;
 import org.apache.ignite.Ignition;
 import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.spi.metric.opencensus.OpenCensusMetricExporterSpi;
+import org.apache.ignite.opencensus.spi.metric.OpenCensusMetricExporterSpi;

Review comment:
       Should be fixed by now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] sanpwc commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
sanpwc commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r451465455



##########
File path: modules/core/src/main/java/org/apache/ignite/spi/tracing/SpanStatus.java
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.spi.tracing;
+
+/**
+ * Various statuses for Spans execution.
+ */
+public enum SpanStatus {

Review comment:
       It's the concept, that we've borrowed from OpenCensus.
   
   > Status defines a logical error model to represent a filterable state of the span at a point in time.
   > Status allows tracing visualization tools to highlight unsuccessful spans and helps in debugging errors.
   
   https://opencensus.io/tracing/span/status/
   In Ignite statuses are used, for example, within discovery handling.
   ```
               if (locNodeId.equals(node.id())) {
                   if (log.isDebugEnabled())
                       log.debug("Received join request for local node, dropping: " + msg);
   
                   msg.spanContainer().span()
                       .addLog(() -> "Dropped")
                       .setStatus(SpanStatus.ABORTED)
                       .end();
   
                   return;
               }
   ```
   Besides other advantages statuses are used for automatic markup in trace visualization tools.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] nizhikov commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r447435239



##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -17,13 +17,13 @@
 
 package org.apache.ignite;
 
+import javax.net.ssl.HostnameVerifier;

Review comment:
       Why this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] nizhikov commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r451471499



##########
File path: examples/src/main/java/org/apache/ignite/examples/opencensus/OpenCensusMetricsExporterExample.java
##########
@@ -31,7 +31,7 @@
 import org.apache.ignite.IgniteCache;
 import org.apache.ignite.Ignition;
 import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.spi.metric.opencensus.OpenCensusMetricExporterSpi;
+import org.apache.ignite.opencensus.spi.metric.OpenCensusMetricExporterSpi;

Review comment:
       This clashes with the existing package hierarchy.
   We place spi's to `org.apache.ignite.spi.SPIPACKAGE`.
   
   Let's keep current naming hierarchy.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] nizhikov commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r451471499



##########
File path: examples/src/main/java/org/apache/ignite/examples/opencensus/OpenCensusMetricsExporterExample.java
##########
@@ -31,7 +31,7 @@
 import org.apache.ignite.IgniteCache;
 import org.apache.ignite.Ignition;
 import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.spi.metric.opencensus.OpenCensusMetricExporterSpi;
+import org.apache.ignite.opencensus.spi.metric.OpenCensusMetricExporterSpi;

Review comment:
       This clashes with the existing package hierarchy.
   We place spi's to `org.apache.ignite.spi.SPIPACKAGE`.
   
   Let's keep current naming hierarchy and revert changes in `OpenCensusMetricExporterSpi`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] nizhikov commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r450832843



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/tracing/SpanManager.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.tracing;
+
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Manager for {@link Span} instances.
+ */
+public interface SpanManager {

Review comment:
       Why do we need two interface `SpanManger` and `Tracing`?
   It seems for me that we can go with the `Tracing` and remove `SpanManager`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] sanpwc commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
sanpwc commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r451469931



##########
File path: examples/src/main/java/org/apache/ignite/examples/opencensus/OpenCensusMetricsExporterExample.java
##########
@@ -31,7 +31,7 @@
 import org.apache.ignite.IgniteCache;
 import org.apache.ignite.Ignition;
 import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.spi.metric.opencensus.OpenCensusMetricExporterSpi;
+import org.apache.ignite.opencensus.spi.metric.OpenCensusMetricExporterSpi;

Review comment:
       Cause besides metrics tracing was added as one of OpenCensus related spis. So at the moment package tree is following:
   ```
   -org.apache.ignite
     -opencensus.spi
       -metric
       -tracing
   ```

##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -17,13 +17,13 @@
 
 package org.apache.ignite;
 
+import javax.net.ssl.HostnameVerifier;

Review comment:
       No reason. Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] sanpwc commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
sanpwc commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r451458735



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/tracing/SpanManager.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.tracing;
+
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Manager for {@link Span} instances.
+ */
+public interface SpanManager {

Review comment:
       Tracing is wider abstraction, that also include configuration. In "next" PR https://github.com/apache/ignite/pull/7974 it'll be updated to following state:
   ```
   /**
    * Tracing sub-system interface.
    */
   public interface Tracing extends SpanManager {
       /**
        * @return Helper to handle traceable messages.
        */
       public TraceableMessagesHandler messages();
   
       /**
        * Returns the {@link TracingConfigurationManager} instance that allows to
        * <ul>
        *     <li>Configure tracing parameters such as sampling rate for the specific tracing coordinates
        *          such as scope and label.</li>
        *     <li>Retrieve the most specific tracing parameters for the specified tracing coordinates (scope and label)</li>
        *     <li>Restore the tracing parameters for the specified tracing coordinates to the default.</li>
        *     <li>List all pairs of tracing configuration coordinates and tracing configuration parameters.</li>
        * </ul>
        * @return {@link TracingConfigurationManager} instance.
        */
       public @NotNull TracingConfigurationManager configuration();
   }
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] dspavlov closed pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
dspavlov closed pull request #7973:
URL: https://github.com/apache/ignite/pull/7973


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] dspavlov commented on pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
dspavlov commented on pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#issuecomment-894334160


   This PR is associated with a resolved ticket. Closing the PR, please reopen it if you still need it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ignite] nizhikov commented on a change in pull request #7973: IGNITE-13060-tracing-engine

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r450834509



##########
File path: modules/core/src/main/java/org/apache/ignite/spi/tracing/SpanStatus.java
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.spi.tracing;
+
+/**
+ * Various statuses for Spans execution.
+ */
+public enum SpanStatus {

Review comment:
       Can you, please, clarify, why do we need this statuses?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org