You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ir...@apache.org on 2018/04/23 20:38:00 UTC
spark git commit: [SPARK-23888][CORE] correct the comment of
hasAttemptOnHost()
Repository: spark
Updated Branches:
refs/heads/master e82cb6834 -> c8f3ac69d
[SPARK-23888][CORE] correct the comment of hasAttemptOnHost()
TaskSetManager.hasAttemptOnHost had a misleading comment. The comment
said that it only checked for running tasks, but really it checked for
any tasks that might have run in the past as well. This updates to line
up with the implementation.
Author: wuyi <ng...@163.com>
Closes #20998 from Ngone51/SPARK-23888.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/c8f3ac69
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/c8f3ac69
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/c8f3ac69
Branch: refs/heads/master
Commit: c8f3ac69d176bd10b8de1c147b6903a247943d51
Parents: e82cb68
Author: wuyi <ng...@163.com>
Authored: Mon Apr 23 15:35:45 2018 -0500
Committer: Imran Rashid <ir...@cloudera.com>
Committed: Mon Apr 23 15:35:50 2018 -0500
----------------------------------------------------------------------
.../src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/c8f3ac69/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala b/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
index d958658..8a96a76 100644
--- a/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
+++ b/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
@@ -287,7 +287,7 @@ private[spark] class TaskSetManager(
None
}
- /** Check whether a task is currently running an attempt on a given host */
+ /** Check whether a task once ran an attempt on a given host */
private def hasAttemptOnHost(taskIndex: Int, host: String): Boolean = {
taskAttempts(taskIndex).exists(_.host == host)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org