You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/27 15:59:02 UTC
[GitHub] [ozone] sumitagrawl commented on a diff in pull request #3853: HDDS-7290. provide a config to increase the list batch size in OzoneFileSystem
sumitagrawl commented on code in PR #3853:
URL: https://github.com/apache/ozone/pull/3853#discussion_r1006683974
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3358,5 +3358,25 @@
</description>
</property>
+ <property>
+ <name>ozone.fs.listing.page.size</name>
+ <value>1024</value>
+ <tag>OZONE, CLIENT</tag>
+ <description>
+ Listing page size value used by client for listing number of items on fs related sub-commands output.
+ Kindly set this config value responsibly to avoid high resource usage. Maximum value restricted is 5000 for
+ optimum performance.
+ </description>
+ </property>
+ <property>
+ <name>ozone.fs.listing.page.size.max</name>
Review Comment:
conf name should specify if its client configuration or om configuration at server
like ozone.om.fs.listing.page.size
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -519,6 +519,20 @@ public final class OzoneConfigKeys {
public static final String OZONE_AUDIT_LOG_DEBUG_CMD_LIST_OMAUDIT =
"ozone.audit.log.debug.cmd.list.omaudit";
+
+ // Items listing page size for fs client sub-commands output
+ public static final String
+ OZONE_FS_LISTING_PAGE_SIZE = "ozone.fs.listing.page.size";
+
+ public static final int
+ OZONE_FS_LISTING_PAGE_SIZE_DEFAULT = 1024;
+
+ public static final int
+ OZONE_FS_MAX_LISTING_PAGE_SIZE = 5000;
Review Comment:
This is default conf for OM side as max limit, rename variable accordingly
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3358,5 +3358,25 @@
</description>
</property>
+ <property>
+ <name>ozone.client.fs.listing.page.size</name>
+ <value>1024</value>
+ <tag>OZONE, CLIENT</tag>
+ <description>
+ Default listing page size value used for listing items on fs related sub-commands output. Kindly set
+ this config value responsibly to avoid high resource usage. Maximum value restricted is 5000 for
+ optimum performance.
+ </description>
+ </property>
+ <property>
+ <name>ozone.server.fs.listing.page.size</name>
+ <value>1024</value>
+ <tag>OZONE, OM</tag>
+ <description>
+ Default listing page size value used for listing items on fs related sub-commands output. Kindly set
+ this config value responsibly to avoid high resource usage. Maximum value restricted is 5000 for
+ optimum performance.
+ </description>
+ </property>
Review Comment:
Either server and client configuratoin need to be same, OR .max is creating confusion with 5000 as upper limit of property, unable to distinguish the difference from code perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org