You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "Jens-G (via GitHub)" <gi...@apache.org> on 2026/09/21 16:58:37 UTC
[PR] THRIFT-6334: Require PHP 8.3 and document the version support policy [thrift]
Jens-G opened a new pull request, #3926:
URL: https://github.com/apache/thrift/pull/3926
Raises the minimum PHP to 8.3 for 0.26.0 and adds a version support policy to `LANGUAGES.md`.
### Why now
- PHP 8.1 reached end of life on 2025-12-31; PHP 8.2 reaches it on 2026-12-31.
- 8.3 is the oldest release still receiving upstream security support, so it is the natural floor for 0.26.0.
- PHP 8.1 additionally carries end-of-life engine defects that upstream will not fix.
### Changes
- `composer.json`: `"php": "^8.1"` → `"^8.3"`; `lib/php/README.md` minimum → 8.3.
- CI: PHP matrix `[8.1, 8.2, 8.3, 8.4, 8.5]` → `[8.3, 8.4, 8.5]`; static-analysis job → 8.3.
- Build images: `ubuntu-jammy` and `ubuntu-focal` → PHP 8.3 (both via `ppa:ondrej/php`); `ubuntu-noble` already ships 8.3.
- `LANGUAGES.md`: PHP `Min` → 8.3, plus a new **Version support policy** section (a guideline, not a hard rule — keep EOL versions only while the cost is manageable, drop when no longer practical).
**Breaking change:** raises the minimum PHP version; users on 8.1/8.2 must upgrade.
Reviewer note: the jammy/focal image rebuilds (jammy gains the ondrej PPA, focal bumps its version) are validated by this PR's CI — they were not rebuilt locally.
Prepared with AI assistance (Claude Opus 4.8); reviewed by the submitter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6334: Require PHP 8.3 and document the version support policy [thrift]
Posted by "sveneld (via GitHub)" <gi...@apache.org>.
sveneld commented on PR #3926:
URL: https://github.com/apache/thrift/pull/3926#issuecomment-5764966655
Based on the support policy proposed in LANGUAGES.md, I don't see an urgent need to raise the minimum PHP version to 8.3. Maintaining compatibility with PHP 8.1 and 8.2 currently seems to require little effort, and we don't have version-specific branches in the runtime code to accommodate them.
I could agree to raising the minimum to 8.2 as a compromise. It still receives upstream security updates until the end of 2026, and I would expect it to remain in use throughout 2027 —even after upstream support ends—as upgrades in real-world projects tend to take a while. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6334: Require PHP 8.3 and document the version support policy [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3926:
URL: https://github.com/apache/thrift/pull/3926#issuecomment-5767711267
> upgrades in real-world projects tend to take a while.
Strange argument. Thrift updates as well then, so where is the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6334: Require PHP 8.2 and document the version support policy [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3926:
URL: https://github.com/apache/thrift/pull/3926#issuecomment-5767796138
Updated: the floor is 8.2 now. It stays there until 2027; once 8.2 has reached its end of life, the policy makes 8.3 the next floor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6334: Require PHP 8.2 and document the version support policy [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3926:
URL: https://github.com/apache/thrift/pull/3926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org