You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Francesco Chicchiriccò (JIRA)" <ji...@apache.org> on 2019/04/14 05:25:00 UTC
[jira] [Updated] (COCOON-2360) [2,2] Inconsistent method names
[ https://issues.apache.org/jira/browse/COCOON-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francesco Chicchiriccò updated COCOON-2360:
-------------------------------------------
Priority: Minor (was: Major)
> [2,2] Inconsistent method names
> -------------------------------
>
> Key: COCOON-2360
> URL: https://issues.apache.org/jira/browse/COCOON-2360
> Project: Cocoon
> Issue Type: Improvement
> Components: Blocks: (Undefined)
> Affects Versions: 2.2
> Reporter: KuiLIU
> Assignee: Francesco Chicchiriccò
> Priority: Minor
> Fix For: 2.2.1
>
>
> The following method is named as "select".
> "select" is prone to mean that something will be selected.
> But this method actually checks whether the expression is contained or not.
> So, rename it as "contains" should be more clearly and intuitively.
> public boolean select( String expression ) {
> return this.set.contains( expression );
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)