[GitHub] [skywalking-php] jmjoy commented on a diff in pull request #39: Fix php-fpm freeze after large amount of request.

[GitBox <gi...@apache.org>]

jmjoy commented on code in PR #39:
URL: https://github.com/apache/skywalking-php/pull/39#discussion_r1063537380


##########
src/worker.rs:
##########
@@ -153,7 +153,7 @@ async fn start_worker(server_addr: String) {
                                     Ok(i) => Ok(i),
                                 };
 
-                                if let Err(err) = tx.send(r).await {
+                                if let Err(err) = tx.try_send(r) {

Review Comment:
   The freeze problem is solved, but I got another problem: `ERROR shutdown: skywalking_agent::channel: channel send failed err=Broken pipe (os error 32)`, I want to solve it together.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org