You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by er...@apache.org on 2020/07/22 14:53:52 UTC
[cordova-cli] branch master updated: chore: drop node-8 deprecation
transition step (#516)
This is an automated email from the ASF dual-hosted git repository.
erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
The following commit(s) were added to refs/heads/master by this push:
new e7b73f0 chore: drop node-8 deprecation transition step (#516)
e7b73f0 is described below
commit e7b73f0dd4b20a7ea7d7244d4f9b85db515af45c
Author: エリス <er...@users.noreply.github.com>
AuthorDate: Wed Jul 22 23:53:42 2020 +0900
chore: drop node-8 deprecation transition step (#516)
---
src/cli.js | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/cli.js b/src/cli.js
index fa6146e..d96e262 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -36,7 +36,7 @@ const semver = require('semver');
const NODE_VERSION = process.version;
// When there is no node version in the deprecation stage, set to null or false.
-const NODE_VERSION_REQUIREMENT = '>=8';
+const NODE_VERSION_REQUIREMENT = false;
const NODE_VERSION_DEPRECATING_RANGE = '<10';
var knownOpts = {
@@ -302,10 +302,15 @@ function cli (inputArgs) {
let warningPartial = null;
// If the Node.js versions does not meet our requirements or in a deprecation stage, display a warning.
- if (!semver.satisfies(NODE_VERSION, NODE_VERSION_REQUIREMENT)) {
+ if (
+ NODE_VERSION_REQUIREMENT &&
+ !semver.satisfies(NODE_VERSION, NODE_VERSION_REQUIREMENT)
+ ) {
warningPartial = 'is no longer supported';
- } else if (NODE_VERSION_DEPRECATING_RANGE &&
- semver.satisfies(NODE_VERSION, NODE_VERSION_DEPRECATING_RANGE)) {
+ } else if (
+ NODE_VERSION_DEPRECATING_RANGE &&
+ semver.satisfies(NODE_VERSION, NODE_VERSION_DEPRECATING_RANGE)
+ ) {
warningPartial = 'has been deprecated';
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org