You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/23 21:21:44 UTC
[GitHub] [netbeans] t-oster opened a new pull request #2559: include web.bootsfaces in cluster.properties #2357
t-oster opened a new pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559
I am not even sure what the cluster.properties does, but since I want my #2357 to be in the next distribution, I guess this is what I have to do?!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #2559: [NETBEANS-5054] include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-733987243
@t-oster It's still a tab. (Please try to check your settings for a tab key. Or please try to input spaces using a space key.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] t-oster commented on pull request #2559: include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
t-oster commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-733592030
@matthiasblaesing thanks for the infos. I did as requested. I overlooked the meesage with the order in the logs... sorry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2559: [NETBEANS-5054] include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-733987243
@t-oster It's still a tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2559: include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-733176485
> @matthiasblaesing is #2559 what I should do? I added it underneath web.primefaces, because that's what it is based on.
The failing unittests give the answer (isn't it nice to get clear errors for once :-)):
https://travis-ci.org/github/apache/netbeans/jobs/745509166#L446
i.e. you need to fix the order. I don't want to discourage you, but this will become part of 12.3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2559: include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-733177459
To give some context: Clusters in Netbeans sources group modules and the build is defined by the set of clusters that are included. The full IDE contains all clusters, one other popular cluster "platform", which only contains the core modules to get a good basis for a swing application. If a module is not part of a cluster it is not reached by the build system and thus not included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] t-oster commented on pull request #2559: [NETBEANS-5054] include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
t-oster commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-733950561
done. my bad, didn't see that in Netbeans ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] t-oster commented on pull request #2559: [NETBEANS-5054] include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
t-oster commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-734101289
I am sorry this took so long for such stupid things. I just forgot to git add before amend. However I wouldn't have minded if anyone had just changed the line in this file and closed this PR since my code is already in #2375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2559: [NETBEANS-5054] include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-734508400
@t-oster Don't worry :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2559: [NETBEANS-5054] include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-734462356
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2559: [NETBEANS-5054] include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2559: include web.bootsfaces in cluster.properties #2357
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2559:
URL: https://github.com/apache/netbeans/pull/2559#issuecomment-733177925
And one final thing: Please update the commit message to hold the reference to the issue in the summary:
"[NETBEANS-5054] include web.bootsfaces in cluster.properties"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists