You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pedro-martins <gi...@git.apache.org> on 2016/03/20 02:02:25 UTC
[GitHub] cloudstack pull request: Removed unused parameters and variable fr...
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/1447
Removed unused parameters and variable from NetworkHelper hierarchy
- Was removed the unused params User & Account in the com.cloud.network.router.NetworkHelper.startVirtualRouter(DomainRouterVO, User, Account, Map<Param, Object>) and the param Long in the com.cloud.network.router.NetworkHelper.destroyRouter(long, Account, Long)
- Also, was removed the unused params User & Account from com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO, User, Account, Map<Param, Object>, DeploymentPlan)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pedro-martins/cloudstack lrg-cs-hackday-032
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1447
----
commit 35bfb918828d3f69a2ae549cedce40177e9bd2aa
Author: pedro-martins <ph...@gmail.com>
Date: 2016-03-19T22:42:35Z
remove unused parameters and variable from NetworkHelper hierarchy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9343 Removed unused parameters...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1447#issuecomment-208320181
@pedro-martins I noticed you updated this PR with a Jira ticket.
Could you elaborate a little bit more on how you found these unused variables?
Was it during some coding process? During another PR review?
If so, please reference here and at the Jira ticket, how you stumbled across. So we can have a history of the discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused parameters and variable fr...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1447#issuecomment-199207256
@pedro-martins How did you validate you didn't break anything? Was this work based on code analysis alone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused parameters and variable fr...
Posted by pedro-martins <gi...@git.apache.org>.
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1447#issuecomment-199337285
Hi @DaanHoogland.
I did a maven install (this executes the unit tests). Also, the PR has passed in the Jenkins and the CI tests. However, I did not execute functional tests (integration tests).
The analysis was done manually; basically, I saw that a method was not using some of its parameters. After that, I checked that this method is an implementation of an interface's method, then I checked all classes that implement that interface (just one), then I analyzed all of the methods in that interface to detect if any other had the same problem with unused parameters and fixed it.
Ty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1447: CLOUDSTACK-9343 Removed unused parameters and variab...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1447
### ACS CI BVT Run
**Sumarry:**
Build Number 156
Hypervisor xenserver
NetworkType Advanced
Passed=68
Failed=5
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_vpc_vpn.py
* ContextSuite context=TestRVPCSite2SiteVpn>:setup Failing since 15 runs
* ContextSuite context=TestVpcRemoteAccessVpn>:setup Failing since 15 runs
* ContextSuite context=TestVpcSite2SiteVpn>:setup Failing since 15 runs
* test_volumes.py
* test_06_download_detached_volume Failing since 2 runs
* test_vm_life_cycle.py
* test_10_attachAndDetach_iso Failing since 2 runs
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---