You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/02 17:08:20 UTC

[GitHub] [spark] srowen commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab

srowen commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r352718162
 
 

 ##########
 File path: streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
 ##########
 @@ -162,7 +163,7 @@ class UISeleniumSuite
         outputOpIds.map(_.text) should be (List("0", "1"))
 
         // Check job ids
-        val jobIdCells = findAll(cssSelector( """#batch-job-table a""")).toSeq
+        val jobIdCells = findAll(cssSelector( """#jobId""")).toSeq
 
 Review comment:
   Is it valid to have duplicate ids in HTML elements? really I was just suggesting you filter the results to only consider numbers. Not entirely robust but maybe sufficient.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org