[GitHub] [turbine-archetypes] gmkll commented on pull request #2: add ko_Kr localized sample

[GitBox <gi...@apache.org>]

gmkll commented on pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2#issuecomment-954793453


   Thanks for this PR, we appreciate it very much! Java 8 requires still latin1 in props files, that is we have to convert it for our current Java 8 supporting Turbine archetype like this:
   
   `native2ascii -encoding UTF-8 src/main/resources/archetype-resources/src/main/java/L10N_ko_KR.properties`
   
   which outputs the utf-8 escaped characters - but unfortunately even then I could not read the characters in the browser,  e.g.  for `$l10n.l10nkey` just some question marks show up -?
   
   IMO: As Java 9 and above support UTF-8 chars in properties files, though, we acknowledge the PR as-is, but wait merging it until we update to java 11 (and above) support -?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org