You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/07/08 22:08:18 UTC
Review Request 36328: Change Request accepts to acceptsEncoding
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36328/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-2860
https://issues.apache.org/jira/browse/MESOS-2860
Repository: mesos-incubating
Description
-------
accepts Request method implement 'Accepts-Encoding', we should change it's name to better reflect this.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 8d9adc5
3rdparty/libprocess/src/encoder.hpp b898658
3rdparty/libprocess/src/http.cpp 0898335
3rdparty/libprocess/src/tests/encoder_tests.cpp 9fccab1
Diff: https://reviews.apache.org/r/36328/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 36328: Change Request accepts to acceptsEncoding
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36328/#review91026
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36328]
All tests passed.
- Mesos ReviewBot
On July 8, 2015, 8:08 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36328/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 8:08 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2860
> https://issues.apache.org/jira/browse/MESOS-2860
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> accepts Request method implement 'Accepts-Encoding', we should change it's name to better reflect this.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 8d9adc5
> 3rdparty/libprocess/src/encoder.hpp b898658
> 3rdparty/libprocess/src/http.cpp 0898335
> 3rdparty/libprocess/src/tests/encoder_tests.cpp 9fccab1
>
> Diff: https://reviews.apache.org/r/36328/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 36328: Change Request accepts to acceptsEncoding
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36328/#review90984
-----------------------------------------------------------
Ship it!
LGTM.
- Anand Mazumdar
On July 8, 2015, 8:08 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36328/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 8:08 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2860
> https://issues.apache.org/jira/browse/MESOS-2860
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> accepts Request method implement 'Accepts-Encoding', we should change it's name to better reflect this.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 8d9adc5
> 3rdparty/libprocess/src/encoder.hpp b898658
> 3rdparty/libprocess/src/http.cpp 0898335
> 3rdparty/libprocess/src/tests/encoder_tests.cpp 9fccab1
>
> Diff: https://reviews.apache.org/r/36328/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 36328: Change Request accepts to acceptsEncoding
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36328/#review91172
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 8, 2015, 8:08 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36328/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 8:08 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2860
> https://issues.apache.org/jira/browse/MESOS-2860
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> accepts Request method implement 'Accepts-Encoding', we should change it's name to better reflect this.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 8d9adc5
> 3rdparty/libprocess/src/encoder.hpp b898658
> 3rdparty/libprocess/src/http.cpp 0898335
> 3rdparty/libprocess/src/tests/encoder_tests.cpp 9fccab1
>
> Diff: https://reviews.apache.org/r/36328/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>