You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2024/03/12 09:33:00 UTC

[jira] [Commented] (OFBIZ-12936) ‎SecuredUpload‎::checkMaxLinesLength put in a regression for PDF files

    [ https://issues.apache.org/jira/browse/OFBIZ-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825588#comment-17825588 ] 

ASF subversion and git services commented on OFBIZ-12936:
---------------------------------------------------------

Commit f62f17753327c9ae249260a363d1b823842a39c1 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f62f177533 ]

Fixed: ‎SecuredUpload‎::checkMaxLinesLength put in a regression for PDF files (OFBIZ-12936)

As commented at https://s.apache.org/wpkuj, while working on OFBIZ-12926
I realised that checkMaxLinesLength put in a possible regression for PDF files.

As a summary: we can't use checkMaxLinesLength for PDF files because they may
contain several CharSet encodings. Hence no possibility to use
Files::readAllLines that needs a sole CharSet. So we need to bypass this check.


> ‎SecuredUpload‎::checkMaxLinesLength put in a regression for PDF files
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-12936
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12936
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/security
>    Affects Versions: 18.12.13
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 18.12.13
>
>
> As commented at [https://s.apache.org/wpkuj,] while working on OFBIZ-12926 I realised that checkMaxLinesLength put in a possible regression for PDF files.
> As a summary: we can't use checkMaxLinesLength for PDF files because they may contain several CharSet encodings. Hence no possibility to use Files::readAllLines that needs a sole CharSet. So we need to bypass this check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)