[GitHub] [skywalking] wu-sheng commented on a change in pull request #4593: [BugFix] Fix wrong H2 column type

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4593: [BugFix] Fix wrong H2 column type
URL: https://github.com/apache/skywalking/pull/4593#discussion_r400252452
 
 

 ##########
 File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2TableInstaller.java
 ##########
 @@ -92,7 +92,7 @@ protected String getColumnType(ModelColumn column) {
         } else if (String.class.equals(type)) {
             return "VARCHAR(" + column.getLength() + ")";
         } else if (IntKeyLongValueHashMap.class.equals(type)) {
-            return "MEDIUMTEXT";
+            return "VARCHAR(20000)";
 
 Review comment:
   Why change this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services