You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/02 06:21:57 UTC
[GitHub] [hudi] dongkelun opened a new pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
dongkelun opened a new pull request #3380:
URL: https://github.com/apache/hudi/pull/3380
What changes were proposed in this pull request?
Support referencing subquery with column aliases by table alias in merge into
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pengzhiwei2018 commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
pengzhiwei2018 commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-898115748
> @pengzhiwei2018 Hi,When I test Spark3, I find that Spark SQL for Hoodie with Spark3 uses the source code of Spark, but columns aliases in Merge Into is not supported in Spark3, it will throw the following exception: 'Columns aliases are not allowed in MERGE.'.I think there are two solutions, one is to modify the source code of Spark3 to make Spark support, the other is to write code in hudi-spark3 to implement Spark SQL for Hoodie, but I personally feel that this is a big change, I do not know if I understand correctly. So I was hoping you could help with some advice.
>
> ` // org.apache.spark.sql.catalyst.parser.AstBuilder
>
> val sourceTableAlias = getTableAliasWithoutColumnAlias(ctx.sourceAlias, "MERGE")
> private def getTableAliasWithoutColumnAlias(
> ctx: TableAliasContext, op: String): Option[String] = {
> if (ctx == null) {
> None
> } else {
> val ident = ctx.strictIdentifier()
> if (ctx.identifierList() != null) {
> throw new ParseException(s"Columns aliases are not allowed in $op.", ctx.identifierList())
> }
> if (ident != null) Some(ident.getText) else None
> }
> }`
I think we can support this feature only for spark2 currently. You can change the test case by `HoodieSqlUtils#isSpark3`, if it spark3, use the `checkException` to validate the exception for spark3, For spark2, check the answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c1ade9c67059a909278dc0704267a50684a967f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pengzhiwei2018 commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
pengzhiwei2018 commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-903119451
> @pengzhiwei2018 Hi,can you please take a look?
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5914eafbe98a0b79bef2b4585ac4e977a630d35 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613)
* f96f8d97e7328b1efd7682aaf624720ccbba848f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c1ade9c67059a909278dc0704267a50684a967f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c1ade9c67059a909278dc0704267a50684a967f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297)
* f5914eafbe98a0b79bef2b4585ac4e977a630d35 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613)
* f96f8d97e7328b1efd7682aaf624720ccbba848f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ffde2bc56872ccca2e97687b30e4063e8c128626 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713)
* 3632e9eddd520447c3fef1303cc87445385cfbb0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ffde2bc56872ccca2e97687b30e4063e8c128626 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713)
* 3632e9eddd520447c3fef1303cc87445385cfbb0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
}, {
"hash" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721",
"triggerID" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d758a76649ab8837d93abcff355fa05f5574d6f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
}, {
"hash" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721",
"triggerID" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"triggerType" : "PUSH"
}, {
"hash" : "7ca910d32da87482207678413b50bb82ff7f8347",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7ca910d32da87482207678413b50bb82ff7f8347",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d758a76649ab8837d93abcff355fa05f5574d6f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721)
* 7ca910d32da87482207678413b50bb82ff7f8347 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
}, {
"hash" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721",
"triggerID" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"triggerType" : "PUSH"
}, {
"hash" : "7ca910d32da87482207678413b50bb82ff7f8347",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1725",
"triggerID" : "7ca910d32da87482207678413b50bb82ff7f8347",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d758a76649ab8837d93abcff355fa05f5574d6f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721)
* 7ca910d32da87482207678413b50bb82ff7f8347 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1725)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c1ade9c67059a909278dc0704267a50684a967f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pengzhiwei2018 commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
pengzhiwei2018 commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-896455558
Good contribution! @dongkelun , can you run the test for spark3? Using the follow
> mvn clean install -DskipTests -Pspark3
> mvn test -Punit-tests -Pspark3 -pl hudi-spark-datasource/hudi-spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c1ade9c67059a909278dc0704267a50684a967f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c1ade9c67059a909278dc0704267a50684a967f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-897632707
@pengzhiwei2018 Hi,When I test Spark3, I find that Spark SQL for Hoodie with Spark3 uses the source code of Spark, but columns aliases in Merge Into is not supported in Spark3, it will throw the following exception: 'Columns aliases are not allowed in MERGE.'.I think there are two solutions, one is to modify the source code of Spark3 to make Spark support, the other is to write code in hudi-spark3 to implement Spark SQL for Hoodie, but I personally feel that this is a big change, I do not know if I understand correctly. So I was hoping you could help with some advice.
` // org.apache.spark.sql.catalyst.parserAstBuilder
val sourceTableAlias = getTableAliasWithoutColumnAlias(ctx.sourceAlias, "MERGE")
private def getTableAliasWithoutColumnAlias(
ctx: TableAliasContext, op: String): Option[String] = {
if (ctx == null) {
None
} else {
val ident = ctx.strictIdentifier()
if (ctx.identifierList() != null) {
throw new ParseException(s"Columns aliases are not allowed in $op.", ctx.identifierList())
}
if (ident != null) Some(ident.getText) else None
}
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-903049257
@pengzhiwei2018 Hi,can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
}, {
"hash" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3632e9eddd520447c3fef1303cc87445385cfbb0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716)
* d758a76649ab8837d93abcff355fa05f5574d6f9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
}, {
"hash" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721",
"triggerID" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"triggerType" : "PUSH"
}, {
"hash" : "7ca910d32da87482207678413b50bb82ff7f8347",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1725",
"triggerID" : "7ca910d32da87482207678413b50bb82ff7f8347",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ca910d32da87482207678413b50bb82ff7f8347 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1725)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f96f8d97e7328b1efd7682aaf624720ccbba848f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618)
* ffde2bc56872ccca2e97687b30e4063e8c128626 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
}, {
"hash" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721",
"triggerID" : "d758a76649ab8837d93abcff355fa05f5574d6f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3632e9eddd520447c3fef1303cc87445385cfbb0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716)
* d758a76649ab8837d93abcff355fa05f5574d6f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1721)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-898210263
> > @pengzhiwei2018 Hi,When I test Spark3, I find that Spark SQL for Hoodie with Spark3 uses the source code of Spark, but columns aliases in Merge Into is not supported in Spark3, it will throw the following exception: 'Columns aliases are not allowed in MERGE.'.I think there are two solutions, one is to modify the source code of Spark3 to make Spark support, the other is to write code in hudi-spark3 to implement Spark SQL for Hoodie, but I personally feel that this is a big change, I do not know if I understand correctly. So I was hoping you could help with some advice.
> > ` // org.apache.spark.sql.catalyst.parser.AstBuilder
> > val sourceTableAlias = getTableAliasWithoutColumnAlias(ctx.sourceAlias, "MERGE")
> > private def getTableAliasWithoutColumnAlias(
> > ctx: TableAliasContext, op: String): Option[String] = {
> > if (ctx == null) {
> > None
> > } else {
> > val ident = ctx.strictIdentifier()
> > if (ctx.identifierList() != null) {
> > throw new ParseException(s"Columns aliases are not allowed in $op.", ctx.identifierList())
> > }
> > if (ident != null) Some(ident.getText) else None
> > }
> > }`
>
> I think we can support this feature only for spark2 currently. You can change the test case by `HoodieSqlUtils#isSpark3`, if it spark3, use the `checkException` to validate the exception for spark3, For spark2, check the answer.
Ok, I'll change the test case as you suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c1ade9c67059a909278dc0704267a50684a967f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297)
* f5914eafbe98a0b79bef2b4585ac4e977a630d35 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-898547246
> > @pengzhiwei2018 Hi,When I test Spark3, I find that Spark SQL for Hoodie with Spark3 uses the source code of Spark, but columns aliases in Merge Into is not supported in Spark3, it will throw the following exception: 'Columns aliases are not allowed in MERGE.'.I think there are two solutions, one is to modify the source code of Spark3 to make Spark support, the other is to write code in hudi-spark3 to implement Spark SQL for Hoodie, but I personally feel that this is a big change, I do not know if I understand correctly. So I was hoping you could help with some advice.
> > ` // org.apache.spark.sql.catalyst.parser.AstBuilder
> > val sourceTableAlias = getTableAliasWithoutColumnAlias(ctx.sourceAlias, "MERGE")
> > private def getTableAliasWithoutColumnAlias(
> > ctx: TableAliasContext, op: String): Option[String] = {
> > if (ctx == null) {
> > None
> > } else {
> > val ident = ctx.strictIdentifier()
> > if (ctx.identifierList() != null) {
> > throw new ParseException(s"Columns aliases are not allowed in $op.", ctx.identifierList())
> > }
> > if (ident != null) Some(ident.getText) else None
> > }
> > }`
>
> I think we can support this feature only for spark2 currently. You can change the test case by `HoodieSqlUtils#isSpark3`, if it spark3, use the `checkException` to validate the exception for spark3, For spark2, check the answer.
Hello, I have modified the test case and passed Spark3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5914eafbe98a0b79bef2b4585ac4e977a630d35 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613)
* f96f8d97e7328b1efd7682aaf624720ccbba848f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-896836947
> Good contribution! @dongkelun , can you run the test for spark3? Using the follow
>
> > mvn clean install -DskipTests -Pspark3
> > mvn test -Punit-tests -Pspark3 -pl hudi-spark-datasource/hudi-spark
@pengzhiwei2018 Hi, when I run Tests with the above command and the result is: 'Tests: Succeeded 66, failed 4, canceled 0, Ignored 0, pending 0', I don't know whether to require all Tests to pass.I ran the test in the master branch, and the result was ‘Tests: succeeded 66, failed 3, canceled 0, ignored 0, pending 0’，Is there something wrong with my configured environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-897632707
@pengzhiwei2018 Hi,When I test Spark3, I find that Spark SQL for Hoodie with Spark3 uses the source code of Spark, but columns aliases in Merge Into is not supported in Spark3, it will throw the following exception: 'Columns aliases are not allowed in MERGE.'.I think there are two solutions, one is to modify the source code of Spark3 to make Spark support, the other is to write code in hudi-spark3 to implement Spark SQL for Hoodie, but I personally feel that this is a big change, I do not know if I understand correctly. So I was hoping you could help with some advice.
` // org.apache.spark.sql.catalyst.parser.AstBuilder
val sourceTableAlias = getTableAliasWithoutColumnAlias(ctx.sourceAlias, "MERGE")
private def getTableAliasWithoutColumnAlias(
ctx: TableAliasContext, op: String): Option[String] = {
if (ctx == null) {
None
} else {
val ident = ctx.strictIdentifier()
if (ctx.identifierList() != null) {
throw new ParseException(s"Columns aliases are not allowed in $op.", ctx.identifierList())
}
if (ident != null) Some(ident.getText) else None
}
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c1ade9c67059a909278dc0704267a50684a967f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297)
* f5914eafbe98a0b79bef2b4585ac4e977a630d35 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-897338826
> > > Good contribution! @dongkelun , can you run the test for spark3? Using the follow
> > > > mvn clean install -DskipTests -Pspark3
> > > > mvn test -Punit-tests -Pspark3 -pl hudi-spark-datasource/hudi-spark
> >
> >
> > @pengzhiwei2018 Hi, when I run Tests with the above command and the result is: 'Tests: Succeeded 66, failed 4, canceled 0, Ignored 0, pending 0', I don't know whether to require all Tests to pass.I ran the test in the master branch, and the result was ‘Tests: succeeded 66, failed 3, canceled 0, ignored 0, pending 0’，Is there something wrong with my configured environment?
>
> Hi @dongkelun , Except the test for ORC will failed for spark3, other test should be ok.
>
> I found you test case has failed in spark3.
>
> > Test MergeInto For Source Table With ColumnAliases *** FAILED ***�[0
>
> Can you fix this for spark3?
Hi @pengzhiwei2018 ,Ok, I'll try my best
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-897632707
@pengzhiwei2018 Hi,When I test Spark3, I find that Spark SQL for Hoodie with Spark3 uses the source code of Spark, but columns aliases in Merge Into is not supported in Spark3, it will throw the following exception: 'Columns aliases are not allowed in MERGE.'.I think there are two solutions, one is to modify the source code of Spark3 to make Spark support, the other is to write code in hudi-spark3 to implement Spark SQL for Hoodie, but I personally feel that this is a big change, I do not know if I understand correctly. So I was hoping you could help with some advice.
` // org.apache.spark.sql.catalyst.parserAstBuilder
val sourceTableAlias = getTableAliasWithoutColumnAlias(ctx.sourceAlias, "MERGE")
private def getTableAliasWithoutColumnAlias(
ctx: TableAliasContext, op: String): Option[String] = {
if (ctx == null) {
None
} else {
val ident = ctx.strictIdentifier()
if (ctx.identifierList() != null) {
throw new ParseException(s"Columns aliases are not allowed in $op.", ctx.identifierList())
}
if (ident != null) Some(ident.getText) else None
}
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pengzhiwei2018 merged pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
pengzhiwei2018 merged pull request #3380:
URL: https://github.com/apache/hudi/pull/3380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f96f8d97e7328b1efd7682aaf624720ccbba848f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618)
* ffde2bc56872ccca2e97687b30e4063e8c128626 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713)
* 3632e9eddd520447c3fef1303cc87445385cfbb0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890760974
After I submitted this PR [https://github.com/apache/hudi/pull/3377](https://github.com/apache/hudi/pull/3377),Then I wondered if this was the same problem with Spark, so I looked at the latest code of Spark and found that Spark had solved this problem in this PR[https://github.com/apache/spark/pull/31444](https://github.com/apache/spark/pull/31444).In order to be consistent with Spark, I resubmitted this new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
}, {
"hash" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716",
"triggerID" : "3632e9eddd520447c3fef1303cc87445385cfbb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3632e9eddd520447c3fef1303cc87445385cfbb0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1716)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-896270528
@pengzhiwei2018 can you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
dongkelun edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-897632707
@pengzhiwei2018 Hi,When I test Spark3, I find that Spark SQL for Hoodie with Spark3 uses the source code of Spark, but columns aliases in Merge Into is not supported in Spark3, it will throw the following exception: 'Columns aliases are not allowed in MERGE.'.I think there are two solutions, one is to modify the source code of Spark3 to make Spark support, the other is to write code in hudi-spark3 to implement Spark SQL for Hoodie, but I personally feel that this is a big change, I do not know if I understand correctly. So I was hoping you could help with some advice.
` // org.apache.spark.sql.catalyst.parserAstBuilder
val sourceTableAlias = getTableAliasWithoutColumnAlias(ctx.sourceAlias, "MERGE")
private def getTableAliasWithoutColumnAlias(
ctx: TableAliasContext, op: String): Option[String] = {
if (ctx == null) {
None
} else {
val ident = ctx.strictIdentifier()
if (ctx.identifierList() != null) {
throw new ParseException(s"Columns aliases are not allowed in $op.", ctx.identifierList())
}
if (ident != null) Some(ident.getText) else None
}
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pengzhiwei2018 commented on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
pengzhiwei2018 commented on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-897317660
> > Good contribution! @dongkelun , can you run the test for spark3? Using the follow
> > > mvn clean install -DskipTests -Pspark3
> > > mvn test -Punit-tests -Pspark3 -pl hudi-spark-datasource/hudi-spark
>
> @pengzhiwei2018 Hi, when I run Tests with the above command and the result is: 'Tests: Succeeded 66, failed 4, canceled 0, Ignored 0, pending 0', I don't know whether to require all Tests to pass.I ran the test in the master branch, and the result was ‘Tests: succeeded 66, failed 3, canceled 0, ignored 0, pending 0’，Is there something wrong with my configured environment?
Hi @dongkelun , Except the test for ORC will failed for spark3, other test should be ok.
I found you test case has failed in spark3.
> Test MergeInto For Source Table With ColumnAliases *** FAILED ***[0
Can you fix this for spark3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f96f8d97e7328b1efd7682aaf624720ccbba848f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3380: [HUDI-2259]Support referencing subquery with column aliases by table alias in me…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3380:
URL: https://github.com/apache/hudi/pull/3380#issuecomment-890756612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1c1ade9c67059a909278dc0704267a50684a967f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1297",
"triggerID" : "1c1ade9c67059a909278dc0704267a50684a967f",
"triggerType" : "PUSH"
}, {
"hash" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1613",
"triggerID" : "f5914eafbe98a0b79bef2b4585ac4e977a630d35",
"triggerType" : "PUSH"
}, {
"hash" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618",
"triggerID" : "f96f8d97e7328b1efd7682aaf624720ccbba848f",
"triggerType" : "PUSH"
}, {
"hash" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713",
"triggerID" : "ffde2bc56872ccca2e97687b30e4063e8c128626",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f96f8d97e7328b1efd7682aaf624720ccbba848f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1618)
* ffde2bc56872ccca2e97687b30e4063e8c128626 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1713)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org