You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/02/18 16:40:33 UTC

[GitHub] [thrift] fishy commented on a change in pull request #2333: Cherry picks for 0.14.0 branch

fishy commented on a change in pull request #2333:
URL: https://github.com/apache/thrift/pull/2333#discussion_r578571626



##########
File path: test/ThriftTest.thrift
##########
@@ -411,3 +411,17 @@ struct StructB {
 struct OptionalSetDefaultTest {
   1: optional set<string> with_default = [ "test" ]
 }
+
+service ConflictingNamesTest {

Review comment:
       OK I'll create another PR to move this part out to a different thrift file, and if needed we can cherry pick that to 0.14.0 branch as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org