[GitHub] graceguo-supercat opened a new pull request #6752: [fix] JS error out when inline edit a new time-series chart title

[GitBox <gi...@apache.org>]

graceguo-supercat opened a new pull request #6752: [fix] JS error out when inline edit a new time-series chart title
URL: https://github.com/apache/incubator-superset/pull/6752
 
 
   Step to reproduce:
   sql lab -> explore -> change to time-series viz type -> inline edit chart title
   will see JS error out
   
   Root cause:
   New chart doesn't have a slice_id. When user inline edit chart title, it will be saved and assign a slice_id. But when annotation component is triggered update, it is still looking for old slice_id 0, which will cause null exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org