You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/04/16 05:30:22 UTC
[GitHub] [trafficcontrol] dmohan001c opened a new pull request #5748: Regions
dmohan001c opened a new pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [ ] This PR fixes #REPLACE_ME OR is not related to any Issue <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- CDN in a Box
- Traffic Ops
- CI tests
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [ ] This PR includes tests OR I have explained why tests are unnecessary
- [ ] This PR includes documentation OR I have explained why documentation is unnecessary
- [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [ ] This PR includes any and all required license headers
- [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r616351671
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -175,15 +226,90 @@ func UpdateTestRegions(t *testing.T) {
if err != nil {
t.Errorf("cannot UPDATE Region by id: %v - %v", err, alert)
}
-
}
-func GetTestRegions(t *testing.T) {
- for _, region := range testData.Regions {
- resp, _, err := TOSession.GetRegionByName(region.Name, nil)
- if err != nil {
- t.Errorf("cannot GET Region by region: %v - %v", err, resp)
+func VerifyPaginationSupportRegion(t *testing.T) {
+
+ qparams := url.Values{}
+ qparams.Set("orderby", "id")
+ regions, _, err := TOSession.GetRegions(qparams, nil)
+ if err != nil {
+ t.Fatalf("cannot GET Regions: %v", err)
+ }
+
+ if len(regions) > 0 {
+ qparams = url.Values{}
+ qparams.Set("orderby", "id")
+ qparams.Set("limit", "1")
+ regionsWithLimit, _, err := TOSession.GetRegions(qparams, nil)
+ if err == nil {
+ if !reflect.DeepEqual(regions[:1], regionsWithLimit) {
+ t.Error("expected GET Regions with limit = 1 to return first result")
+ }
+ } else {
+ t.Error("Error in getting regions by limit")
}
+
+ if len(regions) > 1 {
Review comment:
oh, you're right, of course. My mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r616353064
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -142,6 +161,38 @@ func SortTestRegions(t *testing.T) {
}
}
+func SortTestRegionsDesc(t *testing.T) {
+
+ respAsc, _, err1 := TOSession.GetRegions(nil, nil)
+ params := url.Values{}
+ params.Set("sortOrder", "desc")
+ respDesc, _, err2 := TOSession.GetRegions(params, nil)
+
+ if err1 != nil {
+ t.Errorf("Expected no error, but got error in Regions Ascending %v", err1)
+ }
+ if err2 != nil {
+ t.Errorf("Expected no error, but got error in Regions Descending %v", err2)
+ }
+ if len(respAsc) == len(respAsc) {
+ if len(respAsc) > 0 && len(respDesc) > 0 {
+ // reverse the descending-sorted response and compare it to the ascending-sorted one
+ for start, end := 0, len(respDesc)-1; start < end; start, end = start+1, end-1 {
+ respDesc[start], respDesc[end] = respDesc[end], respDesc[start]
+ }
+ if respDesc[0].Name != "" && respAsc[0].Name != "" {
+ if !reflect.DeepEqual(respDesc[0].Name, respAsc[0].Name) {
+ t.Errorf("Regions responses are not equal after reversal: %s - %s", respDesc[0].Name, respAsc[0].Name)
+ }
+ }
+ } else {
+ t.Errorf("No Response returned from GET Regions using SortOrder")
+ }
+ } else {
+ t.Fatalf("Region response length are not equal %v %v", respAsc, respAsc)
Review comment:
I think you wanted to print `respAsc` and `descAsc` here, not `respAsc` twice - but also maybe you only wanted to print the lengths?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] dmohan001c commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
dmohan001c commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r615903236
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -175,15 +222,69 @@ func UpdateTestRegions(t *testing.T) {
if err != nil {
t.Errorf("cannot UPDATE Region by id: %v - %v", err, alert)
}
-
}
-func GetTestRegions(t *testing.T) {
- for _, region := range testData.Regions {
- resp, _, err := TOSession.GetRegionByName(region.Name, nil)
- if err != nil {
- t.Errorf("cannot GET Region by region: %v - %v", err, resp)
- }
+func VerifyPaginationSupportRegion(t *testing.T) {
+ qparams := url.Values{}
+ qparams.Set("orderby", "id")
+ regions, _, err := TOSession.GetRegions(qparams, nil)
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r616351671
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -175,15 +226,90 @@ func UpdateTestRegions(t *testing.T) {
if err != nil {
t.Errorf("cannot UPDATE Region by id: %v - %v", err, alert)
}
-
}
-func GetTestRegions(t *testing.T) {
- for _, region := range testData.Regions {
- resp, _, err := TOSession.GetRegionByName(region.Name, nil)
- if err != nil {
- t.Errorf("cannot GET Region by region: %v - %v", err, resp)
+func VerifyPaginationSupportRegion(t *testing.T) {
+
+ qparams := url.Values{}
+ qparams.Set("orderby", "id")
+ regions, _, err := TOSession.GetRegions(qparams, nil)
+ if err != nil {
+ t.Fatalf("cannot GET Regions: %v", err)
+ }
+
+ if len(regions) > 0 {
+ qparams = url.Values{}
+ qparams.Set("orderby", "id")
+ qparams.Set("limit", "1")
+ regionsWithLimit, _, err := TOSession.GetRegions(qparams, nil)
+ if err == nil {
+ if !reflect.DeepEqual(regions[:1], regionsWithLimit) {
+ t.Error("expected GET Regions with limit = 1 to return first result")
+ }
+ } else {
+ t.Error("Error in getting regions by limit")
}
+
+ if len(regions) > 1 {
Review comment:
oh,. you're right, of course. My mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] dmohan001c commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
dmohan001c commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r615807967
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -142,6 +159,36 @@ func SortTestRegions(t *testing.T) {
}
}
+func SortTestRegionsDesc(t *testing.T) {
+
+ var header http.Header
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] dmohan001c commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
dmohan001c commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r616345650
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -175,15 +226,90 @@ func UpdateTestRegions(t *testing.T) {
if err != nil {
t.Errorf("cannot UPDATE Region by id: %v - %v", err, alert)
}
-
}
-func GetTestRegions(t *testing.T) {
- for _, region := range testData.Regions {
- resp, _, err := TOSession.GetRegionByName(region.Name, nil)
- if err != nil {
- t.Errorf("cannot GET Region by region: %v - %v", err, resp)
+func VerifyPaginationSupportRegion(t *testing.T) {
+
+ qparams := url.Values{}
+ qparams.Set("orderby", "id")
+ regions, _, err := TOSession.GetRegions(qparams, nil)
+ if err != nil {
+ t.Fatalf("cannot GET Regions: %v", err)
+ }
+
+ if len(regions) > 0 {
+ qparams = url.Values{}
+ qparams.Set("orderby", "id")
+ qparams.Set("limit", "1")
+ regionsWithLimit, _, err := TOSession.GetRegions(qparams, nil)
+ if err == nil {
+ if !reflect.DeepEqual(regions[:1], regionsWithLimit) {
+ t.Error("expected GET Regions with limit = 1 to return first result")
+ }
+ } else {
+ t.Error("Error in getting regions by limit")
}
+
+ if len(regions) > 1 {
Review comment:
yes, if the condition falls `if len(regions) > 1` it should be greater than or equal to 2. It won't segfault.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r615970498
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -175,15 +226,90 @@ func UpdateTestRegions(t *testing.T) {
if err != nil {
t.Errorf("cannot UPDATE Region by id: %v - %v", err, alert)
}
-
}
-func GetTestRegions(t *testing.T) {
- for _, region := range testData.Regions {
- resp, _, err := TOSession.GetRegionByName(region.Name, nil)
- if err != nil {
- t.Errorf("cannot GET Region by region: %v - %v", err, resp)
+func VerifyPaginationSupportRegion(t *testing.T) {
+
+ qparams := url.Values{}
+ qparams.Set("orderby", "id")
+ regions, _, err := TOSession.GetRegions(qparams, nil)
+ if err != nil {
+ t.Fatalf("cannot GET Regions: %v", err)
+ }
+
+ if len(regions) > 0 {
+ qparams = url.Values{}
+ qparams.Set("orderby", "id")
+ qparams.Set("limit", "1")
+ regionsWithLimit, _, err := TOSession.GetRegions(qparams, nil)
+ if err == nil {
+ if !reflect.DeepEqual(regions[:1], regionsWithLimit) {
+ t.Error("expected GET Regions with limit = 1 to return first result")
+ }
+ } else {
+ t.Error("Error in getting regions by limit")
}
+
+ if len(regions) > 1 {
Review comment:
The `regions` slice in here is sliced to `1:2` which will segfault if it can't get index `1` (or, equivalently, `:2`) - which would mean they need to have a length of at least 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] dmohan001c commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
dmohan001c commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r615808468
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -243,3 +343,39 @@ func DeleteTestRegions(t *testing.T) {
}
}
}
+
+func DeleteTestRegionsByInvalidId(t *testing.T) {
+ i := 10000
+ delResp, _, err := TOSession.DeleteRegion(&i, nil)
+ if err == nil {
+ t.Errorf("cannot DELETE Regions by Invalid ID: %v - %v", err, delResp)
+ }
+}
+
+func DeleteTestRegionsByInvalidName(t *testing.T) {
+ i := "invalid"
+ delResp, _, err := TOSession.DeleteRegion(nil, &i)
+ if err == nil {
+ t.Errorf("cannot DELETE Regions by Invalid ID: %v - %v", err, delResp)
+ }
+}
+
+func GetRegionByInvalidId(t *testing.T) {
+ regionResp, _, err := TOSession.GetRegionByID(10000, nil)
+ if err != nil {
+ t.Errorf("Error!! Getting Region by Invalid ID %v", err)
+ }
+ if len(regionResp) >= 1 {
+ t.Errorf("Error!! Invalid ID shouldn't have any response %v Error %v", regionResp, err)
+ }
+}
+
+func GetRegionByInvalidName(t *testing.T) {
+ regionResp, _, err := TOSession.GetRegionByName("abcd", nil)
+ if err != nil {
+ t.Errorf("Error!! Getting Region by Invalid Name %v", err)
+ }
+ if len(regionResp) >= 1 {
+ t.Errorf("Error!! Invalid Name shouldn't have any response %v Error %v", regionResp, err)
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] dmohan001c commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
dmohan001c commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r615808365
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -142,6 +159,36 @@ func SortTestRegions(t *testing.T) {
}
}
+func SortTestRegionsDesc(t *testing.T) {
+
+ var header http.Header
+ respAsc, _, err1 := TOSession.GetRegions(nil, header)
+ params := url.Values{}
+ params.Set("sortOrder", "desc")
+ respDesc, _, err2 := TOSession.GetRegions(params, header)
+
+ if err1 != nil {
+ t.Errorf("Expected no error, but got error in Regions Ascending %v", err1)
+ }
+ if err2 != nil {
+ t.Errorf("Expected no error, but got error in Regions Descending %v", err2)
+ }
+
+ if len(respAsc) > 0 && len(respDesc) > 0 {
+ // reverse the descending-sorted response and compare it to the ascending-sorted one
+ for start, end := 0, len(respDesc)-1; start < end; start, end = start+1, end-1 {
+ respDesc[start], respDesc[end] = respDesc[end], respDesc[start]
+ }
+ if respDesc[0].Name != "" && respAsc[0].Name != "" {
+ if !reflect.DeepEqual(respDesc[0].Name, respAsc[0].Name) {
+ t.Errorf("Regions responses are not equal after reversal: %s - %s", *&respDesc[0].Name, *&respAsc[0].Name)
Review comment:
Fixed.,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r614973553
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -142,6 +159,36 @@ func SortTestRegions(t *testing.T) {
}
}
+func SortTestRegionsDesc(t *testing.T) {
+
+ var header http.Header
Review comment:
just so you know, `nil` is a valid `http.Header` value, so you can just pass `nil` if you don't need the header
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -175,15 +222,69 @@ func UpdateTestRegions(t *testing.T) {
if err != nil {
t.Errorf("cannot UPDATE Region by id: %v - %v", err, alert)
}
-
}
-func GetTestRegions(t *testing.T) {
- for _, region := range testData.Regions {
- resp, _, err := TOSession.GetRegionByName(region.Name, nil)
- if err != nil {
- t.Errorf("cannot GET Region by region: %v - %v", err, resp)
- }
+func VerifyPaginationSupportRegion(t *testing.T) {
+ qparams := url.Values{}
+ qparams.Set("orderby", "id")
+ regions, _, err := TOSession.GetRegions(qparams, nil)
Review comment:
This test contains many lines that will segfault if the length of `regions` is not at least 3 - which it should check for
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -243,3 +343,39 @@ func DeleteTestRegions(t *testing.T) {
}
}
}
+
+func DeleteTestRegionsByInvalidId(t *testing.T) {
+ i := 10000
+ delResp, _, err := TOSession.DeleteRegion(&i, nil)
+ if err == nil {
+ t.Errorf("cannot DELETE Regions by Invalid ID: %v - %v", err, delResp)
+ }
+}
+
+func DeleteTestRegionsByInvalidName(t *testing.T) {
+ i := "invalid"
+ delResp, _, err := TOSession.DeleteRegion(nil, &i)
+ if err == nil {
+ t.Errorf("cannot DELETE Regions by Invalid ID: %v - %v", err, delResp)
+ }
+}
+
+func GetRegionByInvalidId(t *testing.T) {
+ regionResp, _, err := TOSession.GetRegionByID(10000, nil)
+ if err != nil {
+ t.Errorf("Error!! Getting Region by Invalid ID %v", err)
+ }
+ if len(regionResp) >= 1 {
+ t.Errorf("Error!! Invalid ID shouldn't have any response %v Error %v", regionResp, err)
+ }
+}
+
+func GetRegionByInvalidName(t *testing.T) {
+ regionResp, _, err := TOSession.GetRegionByName("abcd", nil)
+ if err != nil {
+ t.Errorf("Error!! Getting Region by Invalid Name %v", err)
+ }
+ if len(regionResp) >= 1 {
+ t.Errorf("Error!! Invalid Name shouldn't have any response %v Error %v", regionResp, err)
Review comment:
You don't need to prefix test errors with "Error!! ", the output's gonna put a big "ERROR" in front of it for you
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -142,6 +159,36 @@ func SortTestRegions(t *testing.T) {
}
}
+func SortTestRegionsDesc(t *testing.T) {
+
+ var header http.Header
+ respAsc, _, err1 := TOSession.GetRegions(nil, header)
+ params := url.Values{}
+ params.Set("sortOrder", "desc")
+ respDesc, _, err2 := TOSession.GetRegions(params, header)
+
+ if err1 != nil {
+ t.Errorf("Expected no error, but got error in Regions Ascending %v", err1)
+ }
+ if err2 != nil {
+ t.Errorf("Expected no error, but got error in Regions Descending %v", err2)
+ }
+
+ if len(respAsc) > 0 && len(respDesc) > 0 {
+ // reverse the descending-sorted response and compare it to the ascending-sorted one
+ for start, end := 0, len(respDesc)-1; start < end; start, end = start+1, end-1 {
+ respDesc[start], respDesc[end] = respDesc[end], respDesc[start]
+ }
+ if respDesc[0].Name != "" && respAsc[0].Name != "" {
+ if !reflect.DeepEqual(respDesc[0].Name, respAsc[0].Name) {
+ t.Errorf("Regions responses are not equal after reversal: %s - %s", *&respDesc[0].Name, *&respAsc[0].Name)
Review comment:
nit but `*&` is a no-op; `*&respDesc.Name` is the same as just `respDesc.Name`
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -142,6 +159,36 @@ func SortTestRegions(t *testing.T) {
}
}
+func SortTestRegionsDesc(t *testing.T) {
+
+ var header http.Header
+ respAsc, _, err1 := TOSession.GetRegions(nil, header)
+ params := url.Values{}
+ params.Set("sortOrder", "desc")
+ respDesc, _, err2 := TOSession.GetRegions(params, header)
+
+ if err1 != nil {
+ t.Errorf("Expected no error, but got error in Regions Ascending %v", err1)
+ }
+ if err2 != nil {
+ t.Errorf("Expected no error, but got error in Regions Descending %v", err2)
+ }
+
+ if len(respAsc) > 0 && len(respDesc) > 0 {
+ // reverse the descending-sorted response and compare it to the ascending-sorted one
+ for start, end := 0, len(respDesc)-1; start < end; start, end = start+1, end-1 {
+ respDesc[start], respDesc[end] = respDesc[end], respDesc[start]
+ }
+ if respDesc[0].Name != "" && respAsc[0].Name != "" {
+ if !reflect.DeepEqual(respDesc[0].Name, respAsc[0].Name) {
+ t.Errorf("Regions responses are not equal after reversal: %s - %s", *&respDesc[0].Name, *&respAsc[0].Name)
+ }
+ }
Review comment:
This test should `Fatal` before this point if the lengths of `respAsc` and `respDesc` are not exactly equal, otherwise code in here will segfault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] dmohan001c commented on a change in pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
dmohan001c commented on a change in pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748#discussion_r615808181
##########
File path: traffic_ops/testing/api/v4/regions_test.go
##########
@@ -142,6 +159,36 @@ func SortTestRegions(t *testing.T) {
}
}
+func SortTestRegionsDesc(t *testing.T) {
+
+ var header http.Header
+ respAsc, _, err1 := TOSession.GetRegions(nil, header)
+ params := url.Values{}
+ params.Set("sortOrder", "desc")
+ respDesc, _, err2 := TOSession.GetRegions(params, header)
+
+ if err1 != nil {
+ t.Errorf("Expected no error, but got error in Regions Ascending %v", err1)
+ }
+ if err2 != nil {
+ t.Errorf("Expected no error, but got error in Regions Descending %v", err2)
+ }
+
+ if len(respAsc) > 0 && len(respDesc) > 0 {
+ // reverse the descending-sorted response and compare it to the ascending-sorted one
+ for start, end := 0, len(respDesc)-1; start < end; start, end = start+1, end-1 {
+ respDesc[start], respDesc[end] = respDesc[end], respDesc[start]
+ }
+ if respDesc[0].Name != "" && respAsc[0].Name != "" {
+ if !reflect.DeepEqual(respDesc[0].Name, respAsc[0].Name) {
+ t.Errorf("Regions responses are not equal after reversal: %s - %s", *&respDesc[0].Name, *&respAsc[0].Name)
+ }
+ }
Review comment:
updated as per review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #5748: TO client api tests for Regions automation
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5748:
URL: https://github.com/apache/trafficcontrol/pull/5748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org