You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2014/08/07 22:26:45 UTC

Re: Review Request 22939: CLOUDSTACK-6460 - CLVM primary storage migration fails due to incorrect identification of source format.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22939/#review49947
-----------------------------------------------------------



plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
<https://reviews.apache.org/r/22939/#comment87405>

    can you remove the trailing whitespace?


- daan Hoogland


On July 23, 2014, 4:30 p.m., Simon Weller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22939/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 4:30 p.m.)
> 
> 
> Review request for cloudstack, edison su and Marcus Sorensen.
> 
> 
> Bugs: CLOUDSTACK-6460
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6460
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Addresses CLOUDSTACK-6460.
> CLVM storage source was being identified as QCOW2, rather than raw when attempting a primary storage migration.  This caused the migration to fail when qemu-img attempted to image the file back from secondary storage to the new primary storage selected. This patch forces CLVM to be treated as RAW while continuing to acquire sourceFormat from other storage types via disk.getFormat();
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java ecf3e08 
> 
> Diff: https://reviews.apache.org/r/22939/diff/
> 
> 
> Testing
> -------
> 
> Stop VM. Migrate from one primary storage to another. Migration completes successfully. Start vm.
> 
> 
> Thanks,
> 
> Simon Weller
> 
>