You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@giraph.apache.org by dlogothetis <gi...@git.apache.org> on 2018/12/11 18:47:55 UTC

[GitHub] giraph pull request #96: GIRAPH-1213: Fix issues with network requests retri...

Github user dlogothetis commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/96#discussion_r239255770
  
    --- Diff: giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
    @@ -1147,8 +1158,11 @@ private void checkRequestsAfterChannelFailure(final Channel channel) {
         resendRequestsWhenNeeded(new Predicate<RequestInfo>() {
           @Override
           public boolean apply(RequestInfo requestInfo) {
    -        return requestInfo.getDestinationAddress().equals(
    -            channel.remoteAddress());
    +        if (requestInfo.getWriteFuture() == null ||
    --- End diff --
    
    When is this condition true?


---