You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/10/01 16:14:31 UTC

[GitHub] couchdb-couch pull request: Fix "initialization from incompatible ...

GitHub user kxepal opened a pull request:

    https://github.com/apache/couchdb-couch/pull/113

    Fix "initialization from incompatible pointer type" warning for icu drv

    It was caused by using ErlDrvSSizeT type instead of ErlDrvSizeT. It
    was not an issue prior to R15 when ErlDrvSSizeT and ErlDrvSizeT where
    basically int's.
    
    Since we raised minimal Erlang release requirement up to R16B03-1,
    there is no reason to maintain compatibility with pre-R15 for driver
    so local COUCH_* types are replaced with ErlDrv* ones.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kxepal/couchdb-couch fix-icu-driver-compilation-warning

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #113
    
----
commit 7d283044ede8afb038accaf355bee6f5af2a72e5
Author: Alexander Shorin <kx...@apache.org>
Date:   2015-10-01T14:12:01Z

    Fix "initialization from incompatible pointer type" warning for icu drv
    
    It was caused by using ErlDrvSSizeT type instead of ErlDrvSizeT. It
    was not an issue prior to R15 when ErlDrvSSizeT and ErlDrvSizeT where
    basically int's.
    
    Since we raised minimal Erlang release requirement up to R16B03-1,
    there is no reason to maintain compatibility with pre-R15 for driver
    so local COUCH_* types are replaced with ErlDrv* ones.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Fix "initialization from incompatible ...

Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:

    https://github.com/apache/couchdb-couch/pull/113#issuecomment-144743094
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Fix "initialization from incompatible ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-couch/pull/113


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---