[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2334: CASSANDRA-15254 Support updates on the virtuabl table SettingsTable (use annotations for property updates validation)

["smiklosovic (via GitHub)" <gi...@apache.org>]

smiklosovic commented on code in PR #2334:
URL: https://github.com/apache/cassandra/pull/2334#discussion_r1241901004


##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -199,6 +200,8 @@ public MemtableOptions()
     // Limit the maximum depth of repair session merkle trees
     @Deprecated
     public volatile Integer repair_session_max_tree_depth = null;
+    @Mutable
+    @ValidatedBy(useClass = DATABASE_DESCRIPTOR_CLASS, useClassMethod = "validateRepairSessionSpace")

Review Comment:
   @Mmuzaf I would expect that if a parameter is called "useClass", then the actual value of that parameter will be indeed a class.
   
       @Mutable
       @ValidatedBy(useClass = DatabaseDescriptor.class, useClassMethod = "validateRepairSessionSpace")
   
   and the in the implementation you would use ".getName()" or something like that.
   
   The minor problem with this approach is that if a class changes its name or location, this would not be updated.
   
   I am not sure we can do the same for "method" as it is not so easy to reference here like class is but it is still an improvement.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org