You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Matej Knopp (JIRA)" <ji...@apache.org> on 2007/05/12 15:04:15 UTC

[jira] Resolved: (WICKET-278) Error pages for HeaderContributor errors are broken

     [ https://issues.apache.org/jira/browse/WICKET-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Knopp resolved WICKET-278.
--------------------------------

    Resolution: Fixed

I believe this is fixed already

> Error pages for HeaderContributor errors are broken
> ---------------------------------------------------
>
>                 Key: WICKET-278
>                 URL: https://issues.apache.org/jira/browse/WICKET-278
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Alastair Maw
>             Fix For: 1.3
>
>
> This manifests itself with lots of java.io.NotSerializableException: wicket.response.StringResponse and errors like this:
> 08:58:09,083  WARN Objects:1287 - Size of failed of object: wicket.markup.html.HeaderPartContainer
> Al says:
> The errors are caused by the Wicket exception page (which is why there  are a million components - they're all the Labels for the various components/traces/whatever).
> This is what I think goes wrong:
> HtmlHeaderContainer throws an exception while rendering, or something, such that its onDetach() is never called on it. This causes the reference it has to headerResponse to never be set to null. It therefore has a ref to a HeaderResponse, which has a ref to the Response object itself.
> We need to fix it so that onDetach() is always called, I guess. Probably need to work out where to put the try {} finally {}, essentially.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.