You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by koushik-das <gi...@git.apache.org> on 2017/02/09 11:00:56 UTC

[GitHub] cloudstack pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to dele...

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1906#discussion_r100281158
  
    --- Diff: plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/OpendaylightElement.java ---
    @@ -156,7 +153,7 @@ public HostVO createHostVOForDirectConnectAgent(HostVO host, StartupCommand[] st
     
         @Override
         public DeleteHostAnswer deleteHost(HostVO host, boolean isForced, boolean isForceDeleteStorage) throws UnableDeleteHostException {
    -        return new DeleteHostAnswer(true);
    +        return null;
    --- End diff --
    
    @syed I am not sure if this is used or maintained by anyone. But the right fix may be to use some checks to return a valid answer or null. How is this handled in some of the other network elements?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to dele...

Posted by Syed Ahmed <sa...@cloudops.com>.
If no action is being taken, the valid answer is to return null. This will
make the listener logic to try the next listener

On Thu, Feb 9, 2017 at 6:00 AM, koushik-das <gi...@git.apache.org> wrote:

> Github user koushik-das commented on a diff in the pull request:
>
>     https://github.com/apache/cloudstack/pull/1906#discussion_r100281158
>
>     --- Diff: plugins/network-elements/opendaylight/src/main/java/
> org/apache/cloudstack/network/opendaylight/OpendaylightElement.java ---
>     @@ -156,7 +153,7 @@ public HostVO createHostVOForDirectConnectAgent(HostVO
> host, StartupCommand[] st
>
>          @Override
>          public DeleteHostAnswer deleteHost(HostVO host, boolean isForced,
> boolean isForceDeleteStorage) throws UnableDeleteHostException {
>     -        return new DeleteHostAnswer(true);
>     +        return null;
>     --- End diff --
>
>     @syed I am not sure if this is used or maintained by anyone. But the
> right fix may be to use some checks to return a valid answer or null. How
> is this handled in some of the other network elements?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>