You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "judahrand (via GitHub)" <gi...@apache.org> on 2023/09/10 07:57:24 UTC
[GitHub] [arrow-datafusion-python] judahrand opened a new pull request, #491: Upgrade to Datafusion 30.0.0
judahrand opened a new pull request, #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on a diff in pull request #491: Upgrade to Datafusion 31.0.0
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#discussion_r1322049858
##########
Cargo.toml:
##########
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "29.0.0"
+version = "31.0.0"
Review Comment:
One thing I'm not sure is if this version of datafusion-python follows DataFusion version.
Jumping from 29.0.0 to 31.0.0 looks not correct to me.
cc @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #491: Upgrade to Datafusion 31.0.0
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#issuecomment-1714504646
DataFusion 31.0.0 has now been released to crates.io
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on a diff in pull request #491: Upgrade to Datafusion 31.0.0
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#discussion_r1322089017
##########
Cargo.toml:
##########
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "29.0.0"
+version = "31.0.0"
Review Comment:
Yea, if arrow-datafusion-python always matches Rust DataFusion, it sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] judahrand commented on pull request #491: Upgrade to Datafusion 31.0.0
Posted by "judahrand (via GitHub)" <gi...@apache.org>.
judahrand commented on PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#issuecomment-1714536007
Should be good to go!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] judahrand commented on a diff in pull request #491: Upgrade to Datafusion 31.0.0
Posted by "judahrand (via GitHub)" <gi...@apache.org>.
judahrand commented on code in PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#discussion_r1322067559
##########
Cargo.toml:
##########
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "29.0.0"
+version = "31.0.0"
Review Comment:
It looked to me like these previously have always matched 🤷♂️ But definitely happy for them not to!
##########
Cargo.toml:
##########
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "29.0.0"
+version = "31.0.0"
Review Comment:
It looked to me like these previously have always matched 🤷♂️ But definitely happy for them not to!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on a diff in pull request #491: Upgrade to Datafusion 31.0.0
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#discussion_r1322049858
##########
Cargo.toml:
##########
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "29.0.0"
+version = "31.0.0"
Review Comment:
One thing I'm not sure is if this version of datafusion-python follows DataFusion version.
Do we skip 30.0.0?
cc @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on a diff in pull request #491: Upgrade to Datafusion 31.0.0
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#discussion_r1322182220
##########
Cargo.toml:
##########
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "29.0.0"
+version = "31.0.0"
Review Comment:
I see. Thanks @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #491: Upgrade to Datafusion 31.0.0
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#discussion_r1322129672
##########
Cargo.toml:
##########
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "29.0.0"
+version = "31.0.0"
Review Comment:
We skipped 30.0.0 due to regression that broke some Python tests. See https://github.com/apache/arrow-datafusion-python/pull/475 for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #491: Upgrade to Datafusion 31.0.0
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491#discussion_r1322131270
##########
Cargo.toml:
##########
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "29.0.0"
+version = "31.0.0"
Review Comment:
oops I meant to link to https://github.com/apache/arrow-datafusion-python/pull/464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove merged pull request #491: Upgrade to Datafusion 31.0.0
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #491:
URL: https://github.com/apache/arrow-datafusion-python/pull/491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org