You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/07/11 09:54:45 UTC
[GitHub] carbondata pull request #2487: [WIP]Fixed Complex type array GC issue
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/2487
[WIP]Fixed Complex type array GC issue
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kumarvishal09/incubator-carbondata arrayissuefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2487.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2487
----
commit a3891a3d73d1201c53d5f218241b3604659dac4d
Author: kumarvishal09 <ku...@...>
Date: 2018-07-11T09:54:08Z
Fixed Complex type array GC issue
----
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2487
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7029/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2487
retest sdv please
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2487
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6019/
---
[GitHub] carbondata pull request #2487: [CARBONDATA-2735]Fixed Performance issue for ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r203608948
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
@@ -201,31 +209,32 @@ private static ColumnPage getComplexLVBytesColumnPage(TableSpec.ColumnSpec colum
throws MemoryException {
// extract length and data, set them to rowOffset and unsafe memory correspondingly
int rowId = 0;
- List<Integer> rowOffset = new ArrayList<>();
- List<Integer> rowLength = new ArrayList<>();
+ TableSpec.ColumnSpec spec = TableSpec.ColumnSpec
+ .newInstance(columnSpec.getFieldName(), DataTypes.INT, ColumnType.MEASURE);
+ ColumnPage rowOffset = ColumnPage.newPage(spec, DataTypes.INT, 1024);
--- End diff --
ok
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2487
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7257/
---
[GitHub] carbondata pull request #2487: [CARBONDATA-2735]Fixed Performance issue for ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r203608964
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
@@ -175,24 +182,25 @@ private static ColumnPage getLVBytesColumnPage(TableSpec.ColumnSpec columnSpec,
throws MemoryException {
// extract length and data, set them to rowOffset and unsafe memory correspondingly
int rowId = 0;
- List<Integer> rowOffset = new ArrayList<>();
- List<Integer> rowLength = new ArrayList<>();
+ TableSpec.ColumnSpec spec = TableSpec.ColumnSpec
+ .newInstance(columnSpec.getFieldName(), DataTypes.INT, ColumnType.MEASURE);
+ ColumnPage rowOffset = ColumnPage.newPage(spec, DataTypes.INT, 1024);
--- End diff --
ok
---
[GitHub] carbondata pull request #2487: [CARBONDATA-2735]Fixed Performance issue for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2487
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2487
retest sdv please
---
[GitHub] carbondata pull request #2487: [CARBONDATA-2735]Fixed Performance issue for ...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r202320940
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
@@ -175,24 +182,25 @@ private static ColumnPage getLVBytesColumnPage(TableSpec.ColumnSpec columnSpec,
throws MemoryException {
// extract length and data, set them to rowOffset and unsafe memory correspondingly
int rowId = 0;
- List<Integer> rowOffset = new ArrayList<>();
- List<Integer> rowLength = new ArrayList<>();
+ TableSpec.ColumnSpec spec = TableSpec.ColumnSpec
+ .newInstance(columnSpec.getFieldName(), DataTypes.INT, ColumnType.MEASURE);
+ ColumnPage rowOffset = ColumnPage.newPage(spec, DataTypes.INT, 1024);
--- End diff --
This default can be equal NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2487
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5908/
---
[GitHub] carbondata issue #2487: [WIP]Fixed Complex type array GC issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2487
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7026/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2487
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5890/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2487
retest sdv please
---
[GitHub] carbondata pull request #2487: [CARBONDATA-2735]Fixed Performance issue for ...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r202319613
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeVarLengthColumnPage.java ---
@@ -40,6 +40,7 @@
@Override
public void freeMemory() {
byteArrayData = null;
+ rowOffset.freeMemory();
--- End diff --
rowOffset.freeMemory also required in SafeDecimalColumnPage.
It will we good practice to call rowOffset.freeMemory in same class it is allocated, call abstract freememory class from derived to ensure any clean up from abstract class
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2487
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5795/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2487
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5806/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2487
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5774/
---
[GitHub] carbondata pull request #2487: [CARBONDATA-2735]Fixed Performance issue for ...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r202321022
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
@@ -201,31 +209,32 @@ private static ColumnPage getComplexLVBytesColumnPage(TableSpec.ColumnSpec colum
throws MemoryException {
// extract length and data, set them to rowOffset and unsafe memory correspondingly
int rowId = 0;
- List<Integer> rowOffset = new ArrayList<>();
- List<Integer> rowLength = new ArrayList<>();
+ TableSpec.ColumnSpec spec = TableSpec.ColumnSpec
+ .newInstance(columnSpec.getFieldName(), DataTypes.INT, ColumnType.MEASURE);
+ ColumnPage rowOffset = ColumnPage.newPage(spec, DataTypes.INT, 1024);
--- End diff --
This default can be equal NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT
---
[GitHub] carbondata pull request #2487: [CARBONDATA-2735]Fixed Performance issue for ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r203608929
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeVarLengthColumnPage.java ---
@@ -40,6 +40,7 @@
@Override
public void freeMemory() {
byteArrayData = null;
+ rowOffset.freeMemory();
--- End diff --
ok
---
[GitHub] carbondata issue #2487: [WIP]Fixed Complex type array GC issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2487
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5798/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2487
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5862/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2487
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5780/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2487
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7085/
---
[GitHub] carbondata issue #2487: [CARBONDATA-2735]Fixed Performance issue for complex...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2487
LGTM
---