You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/21 05:29:51 UTC
[GitHub] [incubator-superset] ktmud opened a new issue #12149: [Engineer] Add ErrorBoundary to page components
ktmud opened a new issue #12149:
URL: https://github.com/apache/incubator-superset/issues/12149
Sometimes pages go completely blank when a JS error happens (#11908, #11759 , #11568 ).
We should wrap major subcomponents to `ErrorBoundary` so users can still navigate off the error state.
@nytai has [raised the issue](https://github.com/apache/incubator-superset/issues/11759#issuecomment-730714595) before. Creating a ticket to keep track of progress.
A recommended list of boundaries to add:
1. Explore
- [ ] Datasource Column
- [ ] Chart Control Column
- [ ] Chart Header
- [x] Chart Render
- [ ] Chart Data Preview
- [ ] DataSource Editor Modal
2. SQL Lab
- [ ] Datasource Sidebar
- [ ] SQL Editor
- [ ] Query Results Preview
3. Dashboard
- [x] Filters
- [ ] Main dashboard body
3. List View Pages
- [ ] Filters
- [ ] List Table View
- [ ] Thumbnails View
4. Home Page
- [ ] Recents
- [ ] Charts
- [ ] Dashboards
- [ ] Saved Queries
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12149: Add ErrorBoundary to page components
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12149:
URL: https://github.com/apache/incubator-superset/issues/12149#issuecomment-753421491
related? https://github.com/apache/incubator-superset/issues/12109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org