[GitHub] [kafka] guozhangwang commented on a change in pull request #11611: MINOR: prefix topics if internal config is set

[GitBox <gi...@apache.org>]

guozhangwang commented on a change in pull request #11611:
URL: https://github.com/apache/kafka/pull/11611#discussion_r772623797



##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -951,6 +951,8 @@
         public static final String IQ_CONSISTENCY_OFFSET_VECTOR_ENABLED = "__iq.consistency.offset"
             + ".vector.enabled__";
 
+        // Private API used to control the usage of consistency offset vectors

Review comment:
       This comment seems irrelevant? It's not for the offset vectors right?

##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
##########
@@ -85,8 +86,13 @@ public void init(final StateStoreContext context, final StateStore root) {
     }
 
     private void initInternal(final InternalProcessorContext<?, ?> context) {
+        final String prefix = StreamsConfig.InternalConfig.getString(

Review comment:
       Could we use `ProcessorContextUtils#changelogFor` here as well? Ditto below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org