You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/28 11:40:38 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37017: [WIP][SQL] Support v2 SHOW FUNCTIONS
MaxGekk opened a new pull request, #37017:
URL: https://github.com/apache/spark/pull/37017
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37017: [WIP][SPARK-39629][SQL] Support v2 SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37017:
URL: https://github.com/apache/spark/pull/37017#issuecomment-1170865892
> This PR only unifies the test, can we add the v2 show functions command?
@cloud-fan I think mixing of tests unification and v2 impl in one PR is not good idea. I would prefer to unify tests first of all, and then try to implement v2. At the moment, I gathered tests only, and going to unify them to be able to run the same tests in v1 and v2 catalogs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #37017:
URL: https://github.com/apache/spark/pull/37017#discussion_r910899375
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowFunctionsSuite.scala:
##########
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import java.util.Locale
+
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW FUNCTIONS` command that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog: `org.apache.spark.sql.execution.command.v1.ShowFunctionsSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowFunctionsSuite`
+ */
+trait ShowFunctionsSuiteBase extends command.ShowFunctionsSuiteBase
+ with command.TestsV1AndV2Commands {
+
+ test("show a function") {
+ withNamespaceAndFun("ns", "iiilog") { (ns, f) =>
+ val totalFuns = sql(s"SHOW FUNCTIONS IN $ns").count()
+ createFunction(f)
+ assert(sql(s"SHOW FUNCTIONS IN $ns").count() - totalFuns === 1)
+ assert(!sql(s"SHOW FUNCTIONS IN $ns").filter("contains(function, 'iiilog')").isEmpty)
+ }
+ }
+
+ test("show a function in the USER name space") {
+ withNamespaceAndFun("ns", "logiii") { (ns, f) =>
+ assert(sql(s"SHOW USER FUNCTIONS IN $ns").count() === 0)
+ createFunction(f)
+ checkAnswer(sql(s"SHOW USER FUNCTIONS IN $ns"), Row(showFun("ns", "logiii")))
+ }
+ }
+
+ test("look up functions in the SYSTEM name space") {
+ withNamespaceAndFun("ns", "date_addi") { (ns, f) =>
+ val systemFuns = sql(s"SHOW SYSTEM FUNCTIONS IN $ns").count()
+ assert(systemFuns > 0)
+ createFunction(f)
+ assert(sql(s"SHOW SYSTEM FUNCTIONS IN $ns").count() === systemFuns)
+ }
+ }
+
+ test("show functions among both user and system defined functions") {
+ withNamespaceAndFun("ns", "current_datei") { (ns, f) =>
+ val allFuns = sql(s"SHOW ALL FUNCTIONS IN $ns").collect()
+ assert(allFuns.nonEmpty)
+ createFunction(f)
+ checkAnswer(
+ sql(s"SHOW ALL FUNCTIONS IN $ns"),
+ allFuns :+ Row(showFun("ns", "current_datei")))
+ }
+ }
+
+ test("show functions matched to the wildcard pattern") {
+ val testFuns = Seq("crc32i", "crc16j", "date1900", "Date1")
+ withNamespaceAndFuns("ns", testFuns) { (ns, funs) =>
+ assert(sql(s"SHOW USER FUNCTIONS IN $ns").isEmpty)
+ funs.foreach(createFunction)
+ checkAnswer(
+ sql(s"SHOW USER FUNCTIONS IN $ns LIKE '*'"),
+ testFuns.map(testFun => Row(showFun("ns", testFun))))
+ checkAnswer(
+ sql(s"SHOW USER FUNCTIONS IN $ns LIKE '*rc*'"),
+ Seq("crc32i", "crc16j").map(testFun => Row(showFun("ns", testFun))))
+ }
+ }
+}
+
+/**
+ * The class contains tests for the `SHOW FUNCTIONS` command to check V1 In-Memory
+ * table catalog.
+ */
+class ShowFunctionsSuite extends ShowFunctionsSuiteBase with CommandSuiteBase {
+ override def commandVersion: String = super[ShowFunctionsSuiteBase].commandVersion
+
+ override protected def createFunction(name: String): Unit = {
+ spark.udf.register(name, (arg1: Int, arg2: String) => arg2 + arg1)
Review Comment:
I borrowed the code from other tests, just hoped it does what I wanted. Just in case, is it possible to create a function in v1 In-Memory catalog from SQL code or I should invoke catalog API directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37017:
URL: https://github.com/apache/spark/pull/37017#issuecomment-1171572332
Merging to master. Thank you, @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37017:
URL: https://github.com/apache/spark/pull/37017#discussion_r910885223
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowFunctionsSuite.scala:
##########
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import java.util.Locale
+
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW FUNCTIONS` command that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog: `org.apache.spark.sql.execution.command.v1.ShowFunctionsSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowFunctionsSuite`
+ */
+trait ShowFunctionsSuiteBase extends command.ShowFunctionsSuiteBase
+ with command.TestsV1AndV2Commands {
+
+ test("show a function") {
+ withNamespaceAndFun("ns", "iiilog") { (ns, f) =>
+ val totalFuns = sql(s"SHOW FUNCTIONS IN $ns").count()
+ createFunction(f)
+ assert(sql(s"SHOW FUNCTIONS IN $ns").count() - totalFuns === 1)
+ assert(!sql(s"SHOW FUNCTIONS IN $ns").filter("contains(function, 'iiilog')").isEmpty)
+ }
+ }
+
+ test("show a function in the USER name space") {
+ withNamespaceAndFun("ns", "logiii") { (ns, f) =>
+ assert(sql(s"SHOW USER FUNCTIONS IN $ns").count() === 0)
+ createFunction(f)
+ checkAnswer(sql(s"SHOW USER FUNCTIONS IN $ns"), Row(showFun("ns", "logiii")))
+ }
+ }
+
+ test("look up functions in the SYSTEM name space") {
+ withNamespaceAndFun("ns", "date_addi") { (ns, f) =>
+ val systemFuns = sql(s"SHOW SYSTEM FUNCTIONS IN $ns").count()
+ assert(systemFuns > 0)
+ createFunction(f)
+ assert(sql(s"SHOW SYSTEM FUNCTIONS IN $ns").count() === systemFuns)
+ }
+ }
+
+ test("show functions among both user and system defined functions") {
+ withNamespaceAndFun("ns", "current_datei") { (ns, f) =>
+ val allFuns = sql(s"SHOW ALL FUNCTIONS IN $ns").collect()
+ assert(allFuns.nonEmpty)
+ createFunction(f)
+ checkAnswer(
+ sql(s"SHOW ALL FUNCTIONS IN $ns"),
+ allFuns :+ Row(showFun("ns", "current_datei")))
+ }
+ }
+
+ test("show functions matched to the wildcard pattern") {
+ val testFuns = Seq("crc32i", "crc16j", "date1900", "Date1")
+ withNamespaceAndFuns("ns", testFuns) { (ns, funs) =>
+ assert(sql(s"SHOW USER FUNCTIONS IN $ns").isEmpty)
+ funs.foreach(createFunction)
+ checkAnswer(
+ sql(s"SHOW USER FUNCTIONS IN $ns LIKE '*'"),
+ testFuns.map(testFun => Row(showFun("ns", testFun))))
+ checkAnswer(
+ sql(s"SHOW USER FUNCTIONS IN $ns LIKE '*rc*'"),
+ Seq("crc32i", "crc16j").map(testFun => Row(showFun("ns", testFun))))
+ }
+ }
+}
+
+/**
+ * The class contains tests for the `SHOW FUNCTIONS` command to check V1 In-Memory
+ * table catalog.
+ */
+class ShowFunctionsSuite extends ShowFunctionsSuiteBase with CommandSuiteBase {
+ override def commandVersion: String = super[ShowFunctionsSuiteBase].commandVersion
+
+ override protected def createFunction(name: String): Unit = {
+ spark.udf.register(name, (arg1: Int, arg2: String) => arg2 + arg1)
Review Comment:
I think this creates a temp function, which doesn't belong to any catalog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
URL: https://github.com/apache/spark/pull/37017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37017:
URL: https://github.com/apache/spark/pull/37017#discussion_r910880918
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowFunctionsSuite.scala:
##########
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import java.util.Locale
+
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW FUNCTIONS` command that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog: `org.apache.spark.sql.execution.command.v1.ShowFunctionsSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowFunctionsSuite`
+ */
+trait ShowFunctionsSuiteBase extends command.ShowFunctionsSuiteBase
+ with command.TestsV1AndV2Commands {
+
+ test("show a function") {
+ withNamespaceAndFun("ns", "iiilog") { (ns, f) =>
+ val totalFuns = sql(s"SHOW FUNCTIONS IN $ns").count()
+ createFunction(f)
+ assert(sql(s"SHOW FUNCTIONS IN $ns").count() - totalFuns === 1)
+ assert(!sql(s"SHOW FUNCTIONS IN $ns").filter("contains(function, 'iiilog')").isEmpty)
+ }
+ }
+
+ test("show a function in the USER name space") {
+ withNamespaceAndFun("ns", "logiii") { (ns, f) =>
+ assert(sql(s"SHOW USER FUNCTIONS IN $ns").count() === 0)
+ createFunction(f)
+ checkAnswer(sql(s"SHOW USER FUNCTIONS IN $ns"), Row(showFun("ns", "logiii")))
+ }
+ }
+
+ test("look up functions in the SYSTEM name space") {
Review Comment:
```suggestion
test("show functions in the SYSTEM name space") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37017: [WIP][SPARK-39629][SQL] Support v2 SHOW FUNCTIONS
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37017:
URL: https://github.com/apache/spark/pull/37017#issuecomment-1170844027
This PR only unifies the test, can we add the v2 show functions command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37017:
URL: https://github.com/apache/spark/pull/37017#issuecomment-1171062321
@cloud-fan Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #37017:
URL: https://github.com/apache/spark/pull/37017#discussion_r911096343
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowFunctionsSuite.scala:
##########
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import java.util.Locale
+
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW FUNCTIONS` command that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog: `org.apache.spark.sql.execution.command.v1.ShowFunctionsSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowFunctionsSuite`
+ */
+trait ShowFunctionsSuiteBase extends command.ShowFunctionsSuiteBase
+ with command.TestsV1AndV2Commands {
+
+ test("show a function") {
+ withNamespaceAndFun("ns", "iiilog") { (ns, f) =>
+ val totalFuns = sql(s"SHOW FUNCTIONS IN $ns").count()
+ createFunction(f)
+ assert(sql(s"SHOW FUNCTIONS IN $ns").count() - totalFuns === 1)
+ assert(!sql(s"SHOW FUNCTIONS IN $ns").filter("contains(function, 'iiilog')").isEmpty)
+ }
+ }
+
+ test("show a function in the USER name space") {
+ withNamespaceAndFun("ns", "logiii") { (ns, f) =>
+ assert(sql(s"SHOW USER FUNCTIONS IN $ns").count() === 0)
+ createFunction(f)
+ checkAnswer(sql(s"SHOW USER FUNCTIONS IN $ns"), Row(showFun("ns", "logiii")))
+ }
+ }
+
+ test("look up functions in the SYSTEM name space") {
+ withNamespaceAndFun("ns", "date_addi") { (ns, f) =>
+ val systemFuns = sql(s"SHOW SYSTEM FUNCTIONS IN $ns").count()
+ assert(systemFuns > 0)
+ createFunction(f)
+ assert(sql(s"SHOW SYSTEM FUNCTIONS IN $ns").count() === systemFuns)
+ }
+ }
+
+ test("show functions among both user and system defined functions") {
+ withNamespaceAndFun("ns", "current_datei") { (ns, f) =>
+ val allFuns = sql(s"SHOW ALL FUNCTIONS IN $ns").collect()
+ assert(allFuns.nonEmpty)
+ createFunction(f)
+ checkAnswer(
+ sql(s"SHOW ALL FUNCTIONS IN $ns"),
+ allFuns :+ Row(showFun("ns", "current_datei")))
+ }
+ }
+
+ test("show functions matched to the wildcard pattern") {
+ val testFuns = Seq("crc32i", "crc16j", "date1900", "Date1")
+ withNamespaceAndFuns("ns", testFuns) { (ns, funs) =>
+ assert(sql(s"SHOW USER FUNCTIONS IN $ns").isEmpty)
+ funs.foreach(createFunction)
+ checkAnswer(
+ sql(s"SHOW USER FUNCTIONS IN $ns LIKE '*'"),
+ testFuns.map(testFun => Row(showFun("ns", testFun))))
+ checkAnswer(
+ sql(s"SHOW USER FUNCTIONS IN $ns LIKE '*rc*'"),
+ Seq("crc32i", "crc16j").map(testFun => Row(showFun("ns", testFun))))
+ }
+ }
+}
+
+/**
+ * The class contains tests for the `SHOW FUNCTIONS` command to check V1 In-Memory
+ * table catalog.
+ */
+class ShowFunctionsSuite extends ShowFunctionsSuiteBase with CommandSuiteBase {
+ override def commandVersion: String = super[ShowFunctionsSuiteBase].commandVersion
+
+ override protected def createFunction(name: String): Unit = {
+ spark.udf.register(name, (arg1: Int, arg2: String) => arg2 + arg1)
Review Comment:
Let's consider this as testing of SHOW FUNCTIONS of temporary functions. If you are ok, I'll rename it to `ShowTempFunctionsSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37017: [SPARK-39641][SQL][TESTS] Unify v1 and v2 SHOW FUNCTIONS tests
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37017:
URL: https://github.com/apache/spark/pull/37017#issuecomment-1171318255
@cloud-fan Could you take a look at this PR one more time, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org