You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (Created) (JIRA)" <ji...@apache.org> on 2012/01/20 17:27:39 UTC
[jira] [Created] (SANDBOX-359) Move License Agreement to file top
Move License Agreement to file top
----------------------------------
Key: SANDBOX-359
URL: https://issues.apache.org/jira/browse/SANDBOX-359
Project: Commons Sandbox
Issue Type: Task
Components: BeanUtils2
Affects Versions: Nightly Builds
Reporter: Benedikt Ritter
Priority: Trivial
Currently, license agreements are located between package declaration and import statements. To stick to conventions, the license agreements should be moved up to the very top of each file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-359) Move License Agreement to file top
Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189893#comment-13189893 ]
Simone Tripodi commented on SANDBOX-359:
----------------------------------------
which convention? the code follows the Maven code style format (see checkstyle configuration) wich allows the license header in the place that is already :)
> Move License Agreement to file top
> ----------------------------------
>
> Key: SANDBOX-359
> URL: https://issues.apache.org/jira/browse/SANDBOX-359
> Project: Commons Sandbox
> Issue Type: Task
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Priority: Trivial
>
> Currently, license agreements are located between package declaration and import statements. To stick to conventions, the license agreements should be moved up to the very top of each file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-359) Move License Agreement to file top
Posted by "Benedikt Ritter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189930#comment-13189930 ]
Benedikt Ritter commented on SANDBOX-359:
-----------------------------------------
Okay, I just looked through trunk of lang3 and collections and saw that they have it at the very top. It's just, what I have seen the most.
> Move License Agreement to file top
> ----------------------------------
>
> Key: SANDBOX-359
> URL: https://issues.apache.org/jira/browse/SANDBOX-359
> Project: Commons Sandbox
> Issue Type: Task
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Priority: Trivial
>
> Currently, license agreements are located between package declaration and import statements. To stick to conventions, the license agreements should be moved up to the very top of each file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-359) Move License Agreement to file top
Posted by "Benedikt Ritter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196150#comment-13196150 ]
Benedikt Ritter commented on SANDBOX-359:
-----------------------------------------
running mvn checkstyle:checkstyle will criticize on every file, that the first line does not match the expected header line: '^ \* Licensed to the Apache Software Foundation \(ASF\) under one\s*$'. ;)
> Move License Agreement to file top
> ----------------------------------
>
> Key: SANDBOX-359
> URL: https://issues.apache.org/jira/browse/SANDBOX-359
> Project: Commons Sandbox
> Issue Type: Task
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Priority: Trivial
>
> Currently, license agreements are located between package declaration and import statements. To stick to conventions, the license agreements should be moved up to the very top of each file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SANDBOX-359) Move License Agreement to file top
Posted by "Simone Tripodi (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi resolved SANDBOX-359.
------------------------------------
Resolution: Fixed
Assignee: Simone Tripodi
fixed on r1237727; if you just run {{mvn checkstyle:checkstyle}}, pom's settings are ignored; run {{svn up && mvn site && && open target/site/checkstyle.html}} instead
> Move License Agreement to file top
> ----------------------------------
>
> Key: SANDBOX-359
> URL: https://issues.apache.org/jira/browse/SANDBOX-359
> Project: Commons Sandbox
> Issue Type: Task
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Assignee: Simone Tripodi
> Priority: Trivial
>
> Currently, license agreements are located between package declaration and import statements. To stick to conventions, the license agreements should be moved up to the very top of each file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira