[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

[GitBox <gi...@apache.org>]

jamesge commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268082594
 
 

 ##########
 File path: src/brpc/socket.cpp
 ##########
 @@ -92,6 +95,13 @@ DEFINE_int32(connect_timeout_as_unreachable, 3,
              "times *continuously*, the error is changed to ENETUNREACH which "
              "fails the main socket as well when this socket is pooled.");
 
+DEFINE_bool(health_check_using_rpc, false, "By default health check succeeds if server"
 
 Review comment:
   这个flag删掉吧，用health_check_path是否为空来代替，这还能更明确地让用户知道这是在假设下游能提供hc接口。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org