You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/02/14 02:21:37 UTC
[GitHub] spark pull request #20605: [SPARK-23419][SPARK-23416][SS] data source v2 wri...
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20605
[SPARK-23419][SPARK-23416][SS] data source v2 write path should re-throw interruption exceptions directly
## What changes were proposed in this pull request?
Streaming execution has a list of exceptions that means interruption, and handle them specially. `WriteToDataSourceV2Exec` should also respect this list and not wrap them with `SparkException`.
## How was this patch tested?
existing test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark write
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20605
----
commit b91a3af185fa8c953648080c24c71664b1ebe646
Author: Wenchen Fan <we...@...>
Date: 2018-02-14T02:18:35Z
data source v2 write path should re-throw interruption exceptions directly
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20605
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20605
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87437/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20605
This seems good to me. My only concern is that we still have to rely/maintain a list of exceptions thrown when the stop method is called... This approach seems not very robust to me, but I don't have a better suggestion.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20605
thanks, merging to master/2.3! Since it's a bug fix so I included it in branch 2.3, please let me know if you have other concerns, cc @sameeragarwal @marmbrus
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20605: [SPARK-23419][SPARK-23416][SS] data source v2 wri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20605
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20605
cc @zsxwing @jose-torres @mgaido91
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20605
**[Test build #87437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87437/testReport)** for PR 20605 at commit [`b91a3af`](https://github.com/apache/spark/commit/b91a3af185fa8c953648080c24c71664b1ebe646).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20605
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20605
**[Test build #87437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87437/testReport)** for PR 20605 at commit [`b91a3af`](https://github.com/apache/spark/commit/b91a3af185fa8c953648080c24c71664b1ebe646).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20605
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by jose-torres <gi...@git.apache.org>.
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20605
LGTM also. I'll still take it as an action item to try and think of a cleaner way to handle stopping a stream.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20605
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/885/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20605: [SPARK-23419][SPARK-23416][SS] data source v2 write path...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20605
Also cc @tdas @marmbrus
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org