You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/05/22 00:35:53 UTC

Review Request 21791: Do not show instance range when there is only one in group

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/
-----------------------------------------------------------

Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.


Bugs: AURORA-455
    https://issues.apache.org/jira/browse/AURORA-455


Repository: aurora


Description
-------

Do not show instance range when there is only one in group


Diffs
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 

Diff: https://reviews.apache.org/r/21791/diff/


Testing
-------

Tested locally.


Thanks,

David McLaughlin

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review43750
-----------------------------------------------------------

Ship it!


Ship It!

- Suman Karumuri


On May 21, 2014, 10:35 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:35 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by Suman Karumuri <ma...@apache.org>.

> On May 28, 2014, 6:42 p.m., David McLaughlin wrote:
> > Ping. This can be shipped to master.

Can you please rebase with master.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review44143
-----------------------------------------------------------


On May 21, 2014, 10:35 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:35 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review44143
-----------------------------------------------------------


Ping. This can be shipped to master.

- David McLaughlin


On May 21, 2014, 10:35 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:35 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by Bill Farner <wf...@apache.org>.

> On May 21, 2014, 10:42 p.m., Bill Farner wrote:
> > I agree with the wording on the ticket more than what's done here.  Having the range displayed when there's one group is still useful to see the instance count quickly.  It also verifies that there are not instances 'missing' (e.g. 4-99 would catch my eye).
> 
> David McLaughlin wrote:
>     My bad, I should have attached a screenshot. 
>     
>     This will just prevent groups with only one instance being shown as a range.
>     
>     e.g.
>     
>     -------------------------
>     0 - 0   |  4 - 15 
>     -------------------------
>     
>     Becomes:
>     
>     -------------------------
>     0       |  4 - 15
>     -------------------------
>

Thanks for clarifying, this looks perfect.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review43664
-----------------------------------------------------------


On May 21, 2014, 10:35 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:35 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by David McLaughlin <da...@dmclaughlin.com>.

> On May 21, 2014, 10:42 p.m., Bill Farner wrote:
> > I agree with the wording on the ticket more than what's done here.  Having the range displayed when there's one group is still useful to see the instance count quickly.  It also verifies that there are not instances 'missing' (e.g. 4-99 would catch my eye).

My bad, I should have attached a screenshot. 

This will just prevent groups with only one instance being shown as a range.

e.g.

-------------------------
0 - 0   |  4 - 15 
-------------------------

Becomes:

-------------------------
0       |  4 - 15
-------------------------


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review43664
-----------------------------------------------------------


On May 21, 2014, 10:35 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:35 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review43664
-----------------------------------------------------------


I agree with the wording on the ticket more than what's done here.  Having the range displayed when there's one group is still useful to see the instance count quickly.  It also verifies that there are not instances 'missing' (e.g. 4-99 would catch my eye).

- Bill Farner


On May 21, 2014, 10:35 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:35 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review43758
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On May 21, 2014, 10:35 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:35 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review44340
-----------------------------------------------------------


Pushed to master.

- Suman Karumuri


On May 28, 2014, 8:32 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 8:32 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js f86c2103636fe3e91fcf103fdbfae6e36670708e 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21791: Do not show instance range when there is only one in group

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/
-----------------------------------------------------------

(Updated May 28, 2014, 8:32 p.m.)


Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.


Changes
-------

Rebased.


Bugs: AURORA-455
    https://issues.apache.org/jira/browse/AURORA-455


Repository: aurora


Description
-------

Do not show instance range when there is only one in group


Diffs (updated)
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js f86c2103636fe3e91fcf103fdbfae6e36670708e 

Diff: https://reviews.apache.org/r/21791/diff/


Testing
-------

Tested locally.


Thanks,

David McLaughlin