You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/01/06 03:12:23 UTC
Re: Review Request 41462: Used SFINAE-friendly `result_of` in
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 2:12 a.m.)
Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van Remoortere.
Summary (updated)
-----------------
Used SFINAE-friendly `result_of` in libprocess.
Bugs: MESOS-4220
https://issues.apache.org/jira/browse/MESOS-4220
Repository: mesos
Description
-------
Used the SFINAE `result_of` implemented in [r41461](https://reviews.apache.org/r/41461/).
Follow-up from [r40114](https://reviews.apache.org/r/40114/).
Diffs
-----
3rdparty/libprocess/include/process/async.hpp b80b60a7ceb5e87eed8cdab17144ae9617485a04
3rdparty/libprocess/include/process/future.hpp bcb5668565298825056f1b48d48efe12d2e56e7c
Diff: https://reviews.apache.org/r/41462/diff/
Testing
-------
`make check` on OS X, compiled on Windows.
Thanks,
Michael Park
Re: Review Request 41462: Used SFINAE-friendly `result_of` in
libprocess.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:43 p.m.)
Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van Remoortere.
Changes
-------
Addressed comments.
Bugs: MESOS-4220
https://issues.apache.org/jira/browse/MESOS-4220
Repository: mesos
Description
-------
Used the SFINAE `result_of` implemented in [r41461](https://reviews.apache.org/r/41461/).
Follow-up from [r40114](https://reviews.apache.org/r/40114/).
Diffs (updated)
-----
3rdparty/libprocess/include/process/async.hpp b80b60a7ceb5e87eed8cdab17144ae9617485a04
3rdparty/libprocess/include/process/future.hpp bcb5668565298825056f1b48d48efe12d2e56e7c
Diff: https://reviews.apache.org/r/41462/diff/
Testing
-------
`make check` on OS X, compiled on Windows.
Thanks,
Michael Park
Re: Review Request 41462: Used SFINAE-friendly `result_of` in
libprocess.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/#review113059
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41459, 41460, 41461, 41462]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 6, 2016, 2:28 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41462/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 2:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4220
> https://issues.apache.org/jira/browse/MESOS-4220
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used the SFINAE `result_of` implemented in [r41461](https://reviews.apache.org/r/41461/).
>
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp b80b60a7ceb5e87eed8cdab17144ae9617485a04
> 3rdparty/libprocess/include/process/future.hpp bcb5668565298825056f1b48d48efe12d2e56e7c
>
> Diff: https://reviews.apache.org/r/41462/diff/
>
>
> Testing
> -------
>
> `make check` on OS X, compiled on Windows.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 41462: Used SFINAE-friendly `result_of` in
libprocess.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/#review114397
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 6, 2016, 2:28 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41462/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 2:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4220
> https://issues.apache.org/jira/browse/MESOS-4220
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used the SFINAE `result_of` implemented in [r41461](https://reviews.apache.org/r/41461/).
>
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp b80b60a7ceb5e87eed8cdab17144ae9617485a04
> 3rdparty/libprocess/include/process/future.hpp bcb5668565298825056f1b48d48efe12d2e56e7c
>
> Diff: https://reviews.apache.org/r/41462/diff/
>
>
> Testing
> -------
>
> `make check` on OS X, compiled on Windows.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 41462: Used SFINAE-friendly `result_of` in
libprocess.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 2:28 a.m.)
Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van Remoortere.
Changes
-------
Rebased.
Bugs: MESOS-4220
https://issues.apache.org/jira/browse/MESOS-4220
Repository: mesos
Description
-------
Used the SFINAE `result_of` implemented in [r41461](https://reviews.apache.org/r/41461/).
Follow-up from [r40114](https://reviews.apache.org/r/40114/).
Diffs (updated)
-----
3rdparty/libprocess/include/process/async.hpp b80b60a7ceb5e87eed8cdab17144ae9617485a04
3rdparty/libprocess/include/process/future.hpp bcb5668565298825056f1b48d48efe12d2e56e7c
Diff: https://reviews.apache.org/r/41462/diff/
Testing
-------
`make check` on OS X, compiled on Windows.
Thanks,
Michael Park